Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stepfunctions): incorrect default documentation for integrationPattern #19936

Merged
merged 1 commit into from
Apr 15, 2022

Conversation

kaizencc
Copy link
Contributor

Fixes #19815


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Apr 15, 2022

@github-actions github-actions bot added effort/small Small work item – less than a day of effort p2 labels Apr 15, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team April 15, 2022 15:15
@mergify
Copy link
Contributor

mergify bot commented Apr 15, 2022

@gitpod-io[bot] is not allowed to run commands

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Apr 15, 2022
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 0aa1cc0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@kaizencc kaizencc added the pr-linter/exempt-test The PR linter will not require test changes label Apr 15, 2022
@mergify
Copy link
Contributor

mergify bot commented Apr 15, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 4cb3b2b into master Apr 15, 2022
@mergify mergify bot deleted the conroy/docs branch April 15, 2022 19:17
StevePotter pushed a commit to StevePotter/aws-cdk that referenced this pull request Apr 27, 2022
…ttern (aws#19936)

Fixes aws#19815

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort p2 pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(stepfunctions-tasks): documented wrong default value of integrationPattern field for EMR step function tasks
3 participants