fix(eks): remove incomplete support for k8s v1.22 #20000
Conversation
|
|
|
Unrelated, but you're the lucky winner for composing the 20,000th github issue! |
rix0rrr
changed the title
robertd
force-pushed
the
revert-eks-1.22
branch
from
b2156d3
to
1d47c22
Compare
This commit reverts addition of the latest version of EKS (1.22) to CDK as there are some incompatibilities between the current lambda-layer-kubectl and v1.22 EKS cluster. Preferably we would have multiple versions fo kubectl lambda layer, but we are currently struggling with package size issues. kubectl is large, and our package is larger, and adding multiple kubectls to it will make it exceed size limits of package managers. So we can't do this right now, until we have invested significant engineering effort into lifting those limitations. In order to not break the backward compatibility with <=1.20 versions, it was decided to revert this addition PR until all the underlying issues around package size issues are resolved. This reverts commit 9a518c5.
robertd
force-pushed
the
revert-eks-1.22
branch
from
1d47c22
to
3ff71af
Compare
|
@comcalvi Build is failing on
|
rix0rrr
changed the title
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Revert "feat(eks): add k8s v1.22 (aws#19756)" This commit reverts addition of the latest version of EKS (1.22) to CDK as there are some incompatibilities between the current lambda-layer-kubectl and v1.22 EKS cluster. Preferably we would have multiple versions fo kubectl lambda layer, but we are currently struggling with package size issues. kubectl is large, and our package is larger, and adding multiple kubectls to it will make it exceed size limits of package managers. So we can't do this right now, until we have invested significant engineering effort into lifting those limitations. In order to not break the backward compatibility with <=1.20 versions, it was decided to revert this addition PR until all the underlying issues around package size issues are resolved. cc @rix0rrr Close aws#19919 ---- ### All Submissions: * [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
Link #15736 |
|
Hello, for anyone interested in re-rolling this PR. We are currently working on a mechanism to be able to add support for more versions of EKS to the AWS CDK. There is a project board here tracking the work: https://github.com/aws/aws-cdk/projects/15. There should be a new Pull Request this week to track as well. |
|
Hi, I'm still wondering when CDK will be able to provide full support for Kubernetes 1.22. Our company is depending on CDK for provisioning EKS, and we are also using some new features of Kubernetes that are only supported on 1.22. For now, we are using aws-cdk-lib 2.20.0 which provides (partial) support of 1.22 and can solve part of our issues, but we can't add new node groups to EKS due to the missing kubectl in CDK library. In the foreseeable future our project may be blocked furthermore due to the lack of support. I do respect that you are having technical difficulties on it but I still hope that the feature can be added back to CDK in the near future. |
|
Hey, |
|
@leadelngalame1611 Support for v1.22 and v1.23 landed in cdk v2.50.0 |
Revert "feat(eks): add k8s v1.22 (#19756)"
This commit reverts addition of the latest version of EKS (1.22) to CDK as there are some incompatibilities between the current lambda-layer-kubectl and v1.22 EKS cluster. Preferably we would have multiple versions fo kubectl lambda layer, but we are currently struggling with package size issues. kubectl is large, and our package is larger, and adding multiple kubectls to it will make it exceed size limits of package managers. So we can't do this right now, until we have invested significant engineering effort into lifting those limitations. In order to not break the backward compatibility with <=1.20 versions, it was decided to revert this addition PR until all the underlying issues around package size issues are resolved.
cc @rix0rrr
Close #19919
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license