Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eks): cluster cannot be created in opt-in regions #20009

Merged
merged 3 commits into from
Apr 22, 2022

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Apr 21, 2022

The default STS endpoint of the v2 JS SDK is the global endpoint,
which does not work in opt-in regions: it has to be the regional
endpoint. Fix this by setting a global environment variable
for the custom resource Lambdas.

Fixes #13748, fixes #15579.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

The default STS endpoint of the v2 JS SDK is the global endpoint,
which does not work in opt-in regions: it has to be the regional
endpoint. Fix this by setting a global environment variable
for the custom resource Lambdas.

Fixes #13748, fixes #15579.
@rix0rrr rix0rrr requested a review from a team April 21, 2022 10:12
@rix0rrr rix0rrr self-assigned this Apr 21, 2022
@gitpod-io
Copy link

gitpod-io bot commented Apr 21, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team April 21, 2022 10:12
@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p2 labels Apr 21, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Apr 21, 2022
@rix0rrr
Copy link
Contributor Author

rix0rrr commented Apr 21, 2022

Build is failing because of this:

@aws-cdk/aws-lambda-python: Virtualenv location: /asset-input/.venv
@aws-cdk/aws-lambda-python: Traceback (most recent call last):
@aws-cdk/aws-lambda-python:   File "/var/lang/bin/pipenv", line 8, in <module>
@aws-cdk/aws-lambda-python:     sys.exit(cli())
@aws-cdk/aws-lambda-python:   File "/var/lang/lib/python3.6/site-packages/pipenv/vendor/click/core.py", line 1128, in __call__
@aws-cdk/aws-lambda-python:     return self.main(*args, **kwargs)
@aws-cdk/aws-lambda-python:   File "/var/lang/lib/python3.6/site-packages/pipenv/cli/options.py", line 56, in main
@aws-cdk/aws-lambda-python:     return super().main(*args, **kwargs, windows_expand_args=False)
@aws-cdk/aws-lambda-python:   File "/var/lang/lib/python3.6/site-packages/pipenv/vendor/click/core.py", line 1053, in main
@aws-cdk/aws-lambda-python:     rv = self.invoke(ctx)
@aws-cdk/aws-lambda-python:   File "/var/lang/lib/python3.6/site-packages/pipenv/vendor/click/core.py", line 1659, in invoke
@aws-cdk/aws-lambda-python:     return _process_result(sub_ctx.command.invoke(sub_ctx))
@aws-cdk/aws-lambda-python:   File "/var/lang/lib/python3.6/site-packages/pipenv/vendor/click/core.py", line 1395, in invoke
@aws-cdk/aws-lambda-python:     return ctx.invoke(self.callback, **ctx.params)
@aws-cdk/aws-lambda-python:   File "/var/lang/lib/python3.6/site-packages/pipenv/vendor/click/core.py", line 754, in invoke
@aws-cdk/aws-lambda-python:     return __callback(*args, **kwargs)
@aws-cdk/aws-lambda-python:   File "/var/lang/lib/python3.6/site-packages/pipenv/vendor/click/decorators.py", line 84, in new_func
@aws-cdk/aws-lambda-python:     return ctx.invoke(f, obj, *args, **kwargs)
@aws-cdk/aws-lambda-python:   File "/var/lang/lib/python3.6/site-packages/pipenv/vendor/click/core.py", line 754, in invoke
@aws-cdk/aws-lambda-python:     return __callback(*args, **kwargs)
@aws-cdk/aws-lambda-python:   File "/var/lang/lib/python3.6/site-packages/pipenv/vendor/click/decorators.py", line 26, in new_func
@aws-cdk/aws-lambda-python:     return f(get_current_context(), *args, **kwargs)
@aws-cdk/aws-lambda-python:   File "/var/lang/lib/python3.6/site-packages/pipenv/cli/command.py", line 345, in lock
@aws-cdk/aws-lambda-python:     pre=pre,
@aws-cdk/aws-lambda-python:   File "/var/lang/lib/python3.6/site-packages/pipenv/core.py", line 1343, in do_init
@aws-cdk/aws-lambda-python:     pypi_mirror=pypi_mirror,
@aws-cdk/aws-lambda-python:   File "/var/lang/lib/python3.6/site-packages/pipenv/core.py", line 846, in do_install_dependencies
@aws-cdk/aws-lambda-python:     deps = [req.as_line(sources=False, include_hashes=False) for req in deps_list]
@aws-cdk/aws-lambda-python:   File "/var/lang/lib/python3.6/site-packages/pipenv/core.py", line 846, in <listcomp>
@aws-cdk/aws-lambda-python:     deps = [req.as_line(sources=False, include_hashes=False) for req in deps_list]
@aws-cdk/aws-lambda-python:   File "/var/lang/lib/python3.6/site-packages/pipenv/vendor/requirementslib/models/requirements.py", line 2795, in as_line
@aws-cdk/aws-lambda-python:     assert self.line_instance is not None
@aws-cdk/aws-lambda-python:   File "/var/lang/lib/python3.6/site-packages/pipenv/vendor/requirementslib/models/requirements.py", line 2553, in line_instance
@aws-cdk/aws-lambda-python:     self.line_instance = self.get_line_instance()
@aws-cdk/aws-lambda-python:   File "/var/lang/lib/python3.6/site-packages/pipenv/vendor/requirementslib/models/requirements.py", line 2547, in get_line_instance
@aws-cdk/aws-lambda-python:     return Line(line)
@aws-cdk/aws-lambda-python:   File "/var/lang/lib/python3.6/site-packages/pipenv/vendor/requirementslib/models/requirements.py", line 171, in __init__
@aws-cdk/aws-lambda-python:     self.parse()
@aws-cdk/aws-lambda-python:   File "/var/lang/lib/python3.6/site-packages/pipenv/vendor/requirementslib/models/requirements.py", line 1289, in parse
@aws-cdk/aws-lambda-python:     self.parse_extras()
@aws-cdk/aws-lambda-python:   File "/var/lang/lib/python3.6/site-packages/pipenv/vendor/requirementslib/models/requirements.py", line 577, in parse_extras
@aws-cdk/aws-lambda-python:     self.line, extras = pip_shims.shims._strip_extras(self.line)
@aws-cdk/aws-lambda-python: TypeError: 'NoneType' object is not callable
@aws-cdk/aws-lambda-python: /codebuild/output/src629009494/src/github.com/aws/aws-cdk/packages/@aws-cdk/core/lib/asset-staging.js:366
@aws-cdk/aws-lambda-python:             throw new Error(`Failed to bundle asset ${this.node.path}, bundle output is located at ${bundleErrorDir}: ${err}`);
@aws-cdk/aws-lambda-python:             ^
@aws-cdk/aws-lambda-python: Error: Failed to bundle asset cdk-integ-lambda-python/my_handler_inline/Code/Stage, bundle output is located at /codebuild/output/src629009494/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-lambda-python/test/cdk-integ.out.function.pipenv/asset.f413087b2f816a18f52e70299f48f239e7a885afa2ef98f8fc01f35c60031a75-error: Error: docker exited with status 1
@aws-cdk/aws-lambda-python:     at AssetStaging.bundle (/codebuild/output/src629009494/src/github.com/aws/aws-cdk/packages/@aws-cdk/core/lib/asset-staging.js:366:19)
@aws-cdk/aws-lambda-python:     at AssetStaging.stageByBundling (/codebuild/output/src629009494/src/github.com/aws/aws-cdk/packages/@aws-cdk/core/lib/asset-staging.js:225:14)
@aws-cdk/aws-lambda-python:     at stageThisAsset (/codebuild/output/src629009494/src/github.com/aws/aws-cdk/packages/@aws-cdk/core/lib/asset-staging.js:76:41)
@aws-cdk/aws-lambda-python:     at Cache.obtain (/codebuild/output/src629009494/src/github.com/aws/aws-cdk/packages/@aws-cdk/core/lib/private/cache.js:28:17)
@aws-cdk/aws-lambda-python:     at new AssetStaging (/codebuild/output/src629009494/src/github.com/aws/aws-cdk/packages/@aws-cdk/core/lib/asset-staging.js:100:48)
@aws-cdk/aws-lambda-python:     at new Asset (/codebuild/output/src629009494/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-s3-assets/lib/asset.js:35:25)
@aws-cdk/aws-lambda-python:     at AssetCode.bind (/codebuild/output/src629009494/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-lambda/lib/code.js:278:26)
@aws-cdk/aws-lambda-python:     at new Function (/codebuild/output/src629009494/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-lambda/lib/function.js:108:33)
@aws-cdk/aws-lambda-python:     at new PythonFunction (/codebuild/output/src629009494/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-lambda-python/lib/function.js:40:9)
@aws-cdk/aws-lambda-python:     at new TestStack (/codebuild/output/src629009494/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-lambda-python/test/integ.function.pipenv.js:17:38)
@aws-cdk/aws-lambda-python:   integ.function.pipenv - Snapshot changed! 26.097s
@aws-cdk/aws-lambda-python: Command exited with status 1

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 4f8fa8b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Apr 22, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit ec06f48 into master Apr 22, 2022
@mergify mergify bot deleted the huijbers/eks-optin branch April 22, 2022 08:50
StevePotter pushed a commit to StevePotter/aws-cdk that referenced this pull request Apr 27, 2022
The default STS endpoint of the v2 JS SDK is the global endpoint,
which does not work in opt-in regions: it has to be the regional
endpoint. Fix this by setting a global environment variable
for the custom resource Lambdas.

Fixes aws#13748, fixes aws#15579.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/medium Medium work item – several days of effort p2
Projects
None yet
3 participants