Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipeline: should work with pnpm #25820

Open
1 of 2 tasks
ahammond opened this issue Jun 1, 2023 · 2 comments
Open
1 of 2 tasks

pipeline: should work with pnpm #25820

ahammond opened this issue Jun 1, 2023 · 2 comments
Labels
@aws-cdk/pipelines CDK Pipelines library effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1

Comments

@ahammond
Copy link
Contributor

ahammond commented Jun 1, 2023

Describe the feature

Currently the pipeline respects npm and yarn. However, it should also by default respect the pnpm package manager.

Use Case

pnpm significantly improves our developer experiences. However cdkPipelines doesn't support it.

Proposed Solution

Update the default CdkSynth to detect pnpm-lock.yaml the same way it currently detects yarn.lock.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.81.0

Environment details (OS name and version, etc.)

irrelevant

@ahammond ahammond added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jun 1, 2023
@github-actions github-actions bot added the @aws-cdk/pipelines CDK Pipelines library label Jun 1, 2023
@peterwoodworth peterwoodworth added p1 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Jun 1, 2023
@tylerwalts
Copy link

tylerwalts commented Dec 6, 2023

+1 this would be very useful. Currently this feature gap adds friction for pnpm users to adopt CodePipelines.

Adding this bit to the top of the commands: [] works, but it adds overhead time to every build that would be saved if it was supported by default:

        'corepack enable',
        'corepack prepare pnpm@latest-8 --activate',
        'pnpm install',

Edit: based on my latest build's CodePipeline log timestamps, the 3 steps above adds a bit over 5 seconds.

@ahammond
Copy link
Contributor Author

ahammond commented May 9, 2024

Could probably tweak the pnpm install line to only run if it sees a pnpm-lock.yaml. Then I could just throw this into our pipeline library and let devs migrate on their own schedule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/pipelines CDK Pipelines library effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1
Projects
None yet
Development

No branches or pull requests

3 participants