aws-step-functions-tasks: Wrong property declared on TaskBaseState props

[protyay]

Describe the feature

The timeout property in the LambdaInvokeProps interface is inherited from the TaskStateBaseProps interface.
This timeout refers to the overall timeout of the state machine.

Why should each state configuration inherit this property ? This should be defined during the construction of the StateMachine instance.

Use Case

Removing the property of timeout from TaskBaseState props would reduce confusion

Proposed Solution

Remove the timeout property from the TaskStateBaseProps .
Overall, timeout property already exists and should be used on the StateMachine construct

Other Information

No response

Acknowledgements

• I may be able to implement this feature request
• This feature might incur a breaking change

CDK version used

2.83

Environment details (OS name and version, etc.)

macOS Venture 13.4

[peterwoodworth]

timeout is deprecated on TaskBaseStateProps, however totalTimeout is available and sets the timeout for the task itself. I'm not sure I understand the exact request here

[github-actions]

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

[protyay]

@peterwoodworth – I see, I have probably not seen the deprecated tag on the timeout field.
I think you meant taskTimeout , because I was not able to find totalTimeout on the TaskStateBaseProps interface.

Also, I have a different question, if the LambdaInvoke task has defined a timeout and also a timeout has been defined during the Lambda definition, then the one which is lesser would take preference, right ?

I'm not sure I understand the exact request here

I think I was referring to a different timeout property, probably from v1. Sorry for the confusion.

[peterwoodworth]

I think you meant taskTimeout , because I was not able to find totalTimeout on the TaskStateBaseProps interface.

Whoops! you're right, my bad 😄

Also, I have a different question, if the LambdaInvoke task has defined a timeout and also a timeout has been defined during the Lambda definition, then the one which is lesser would take preference, right ?

I'm not positive, but I think this would effectively be the case. There might be a very slight difference between the two, depending on if the task takes a slight amount of the timeout window to invoke the function and receive the result or not

[github-actions]

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.