DockerImageAsset: it fails to deploy to 2 regions

[danielpid]

Describe the bug

I have a CDK stack with DockerImageAsset that I use to deploy to 2 different regions.
The instance of the second stack is not pushed to ECR

Expected Behavior

The image is present in the ECR of both regions

Current Behavior

Only the first stack is correctly pushing the image to ECR

Reproduction Steps

sample-cdk-stack.ts

import * as cdk from "aws-cdk-lib";
import { DockerImageAsset } from "aws-cdk-lib/aws-ecr-assets";
import { Construct } from "constructs";
import path = require("path");
export class SampleCdkStack extends cdk.Stack {
  constructor(scope: Construct, id: string, props?: cdk.StackProps) {
    super(scope, id, props);

    const { env } = props!;

    const image = new DockerImageAsset(
      this,
      `MultiRegionImage-${env?.region}`,
      {
        directory: path.join(__dirname, ".."),
      }
    );

    new cdk.CfnOutput(this, "ImageUri", {
      value: image.imageUri,
    });
  }
}

sample-cdk.ts

#!/usr/bin/env node
import "source-map-support/register";
import * as cdk from "aws-cdk-lib";
import { SampleCdkStack } from "../lib/sample-cdk-stack";

const app = new cdk.App();

new SampleCdkStack(app, "SampleCdkStackFrankfurt", {
  env: { account: "***", region: "eu-central-1" },
});

new SampleCdkStack(app, "SampleCdkStackLondon", {
  env: { account: "***", region: "eu-west-2" },
});

The DcokerImage can be a simple express application

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.83.1

Framework Version

No response

Node.js Version

v16.15.1

OS

macOS Monterey 12.4

Language

Typescript

Language Version

~5.0.4

Other information

No response

[pahud]

Have you tried extraHash?

    const region = props.env!.region

    const image = new ecrassets.DockerImageAsset(this, `MultiRegionImage-${region}`, {
        directory: path.join(__dirname, "../docker.d"),
        extraHash: region,
    });

[peterwoodworth]

@pahud if this is required to deploy to multiple regions, we should add this to the readme.

[danielpid]

Hi @pahud, @peterwoodworth,
Thanks for your response, I confirm that by adding that parameter the issue is gone.
If you ask me, apart from updating the documentation, I'd throw some error or at least a warning when the image was not successfully pushed to ECR using that class.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

[tmokmss]

I confirmed this issue was introduced on v2.80.0. Maybe related with #25536. Can you check this? @rix0rrr @kaizencc

[tmokmss]

The root cause for this issue is that a tag for imageUri is only added on build phase, which runs only once per asset hash, where it is actually required for each region.

aws-cdk/packages/cdk-assets/lib/private/handlers/container-images.ts

Line 45 in 05d875b

await dockerForBuilding.tag(localTagName, initOnce.imageUri);

We may want to move this tagging process to the publish phase. We have to somehow pass the localTagName (especially for an image built by buildExternalAsset).