Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-secretsmanager): broken link to aws-rds #26037

Closed
azatoth opened this issue Jun 19, 2023 · 3 comments
Closed

(aws-secretsmanager): broken link to aws-rds #26037

azatoth opened this issue Jun 19, 2023 · 3 comments
Labels
@aws-cdk/aws-secretsmanager Related to AWS Secrets Manager documentation This is a problem with documentation. duplicate This issue is a duplicate. effort/small Small work item – less than a day of effort p2

Comments

@azatoth
Copy link
Contributor

azatoth commented Jun 19, 2023

Describe the issue

On the last line of the rotating database section, there's a link to aws-rds, but that link resolves to https://github.com/aws/aws-cdk/blob/main/packages/%40aws-cdk/aws-rds/README.md, and not intra-document-wise to the RDS section at https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_rds-readme.html.

Links

https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_secretsmanager-readme.html#rotating-database-credentials
@azatoth azatoth added documentation This is a problem with documentation. needs-triage This issue or PR still needs to be triaged. labels Jun 19, 2023
@github-actions github-actions bot added the @aws-cdk/aws-secretsmanager Related to AWS Secrets Manager label Jun 19, 2023
@pahud
Copy link
Contributor

pahud commented Jun 19, 2023

We should fix that in this README. Are you interested to submit a PR for that?

@pahud pahud added p2 effort/small Small work item – less than a day of effort response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. and removed needs-triage This issue or PR still needs to be triaged. response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. labels Jun 19, 2023
@peterwoodworth peterwoodworth mentioned this issue Jun 19, 2023
Open
@peterwoodworth peterwoodworth added the duplicate This issue is a duplicate. label Jun 19, 2023
@peterwoodworth
Copy link
Contributor

Thanks for reporting, closing in favor of #24958

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

This was referenced Jul 26, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-secretsmanager Related to AWS Secrets Manager documentation This is a problem with documentation. duplicate This issue is a duplicate. effort/small Small work item – less than a day of effort p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@azatoth @pahud @peterwoodworth