stepfunctions: CDK to CFN template is serializing incorrectly

[srivastavr]

Describe the bug

Issue Description

Hi,

We are passing array of array in payload from step function to a lambda function, below is the sample code

            lambdaFunction: serviceCallHandler,
            resultSelector: resultSelector,
            resultPath: resultPath,
            payload: TaskInput.fromObject({
                key1: [
                    [
                        {
                            key2: {
                                key3: 'value1',
                            },
                            key4: [
                                [
                                    {
                                        key5: {
                                            key6: 'value2',
                                        },
                                    },
                                ],
                            ],
                        },
                    ],
                ],
            }),
        }

but after building, the cloud formation template converts this into array of objects with 0 index at places which is incorrect.

like this

 {
        "Ref": "AWS::Partition"
       },
       ":states:::lambda:invoke\",\"Parameters\":{\"FunctionName\":\"",
       {
        "Fn::GetAtt": [
         "servicecallhandler3F6E12B2",
         "Arn"
        ]
       },
       "\",\"Payload\":{\"key1\":[{\"0\":{\"key2\":{\"key3\":\"value1\"},\"key4\":[{\"0\":{\"key5\":{\"key6\":\"value2\"}}}]}}]}}}

Expected Behavior

 {
        "Ref": "AWS::Partition"
       },
       ":states:::lambda:invoke\",\"Parameters\":{\"FunctionName\":\"",
       {
        "Fn::GetAtt": [
         "servicecallhandler3F6E12B2",
         "Arn"
        ]
       },
       "\",\"Payload\":{\"key1\":[[{\"key2\":{\"key3\":\"value1\"},\"key4\":[[{\"key5\":{\"key6\":\"value2\"}]}]}}]]}}

Observed Behavior

Test Cases

NA

Other Details

No response

Expected Behavior

 {
        "Ref": "AWS::Partition"
       },
       ":states:::lambda:invoke\",\"Parameters\":{\"FunctionName\":\"",
       {
        "Fn::GetAtt": [
         "servicecallhandler3F6E12B2",
         "Arn"
        ]
       },
       "\",\"Payload\":{\"key1\":[[{\"key2\":{\"key3\":\"value1\"},\"key4\":[[{\"key5\":{\"key6\":\"value2\"}]}]}}]]}}

Current Behavior

{
        "Ref": "AWS::Partition"
       },
       ":states:::lambda:invoke\",\"Parameters\":{\"FunctionName\":\"",
       {
        "Fn::GetAtt": [
         "servicecallhandler3F6E12B2",
         "Arn"
        ]
       },
       "\",\"Payload\":{\"key1\":[{\"0\":{\"key2\":{\"key3\":\"value1\"},\"key4\":[{\"0\":{\"key5\":{\"key6\":\"value2\"}}}]}}]}}}

Reproduction Steps

building the typescript code

Possible Solution

The serialization is implemented in CDK:

aws-cdk/packages/aws-cdk-lib/aws-stepfunctions/lib/input.ts

Lines 21 to 23 in a79794e

	public static fromObject(obj: { [key: string]: any }) {
	return new TaskInput(InputType.OBJECT, obj);
	}

Additional Information/Context

No response

CDK CLI Version

"aws-cdk": "^2.72.0"

Framework Version

No response

Node.js Version

NodeJS/releases/default.331411.0

OS

Linux

Language

Typescript

Language Version

"typescript": "^4.9.4"

Other information

No response

[srivastavr]

reference from CFN : aws-cloudformation/cloudformation-coverage-roadmap#1722

[pahud]

This is the code I used to reproduce this issue

export class Demo2Stack extends Stack {
  constructor(scope: Construct, id: string, props?: StackProps) {
    super(scope, id, props);

    const obj = {
      key1: [
          [
              {
                  key2: {
                      key3: 'value1',
                  },
                  key4: [
                      [
                          {
                              key5: {
                                  key6: 'value2',
                              },
                          },
                      ],
                  ],
              },
          ],
      ],
    }
    const payload = sfn.TaskInput.fromObject(obj)
    const invoke = new sfntasks.LambdaInvoke(this, 'Invoke Func', {
      lambdaFunction: getLambdaFunction(this),
      payload,
    });

    new sfn.StateMachine(this, 'StateMachine', {
      definition: invoke,
    })
    
    new CfnOutput(this, 'input', { value: JSON.stringify(payload) })
  };
};

I can confirm the CfnOutput is serialized correctly:

Outputs:
  input:
    Value: '{"type":1,"value":{"key1":[[{"key2":{"key3":"value1"},"key4":[[{"key5":{"key6":"value2"}}]]}]]}}'

But the state machine DefinitionString is not serialized correctly:

 StateMachine2E01A3A5:
    Type: AWS::StepFunctions::StateMachine
    Properties:
      RoleArn:
        Fn::GetAtt:
          - StateMachineRoleB840431D
          - Arn
      DefinitionString:
        Fn::Join:
          - ""
          - - '{"StartAt":"Invoke Func","States":{"Invoke Func":{"End":true,"Retry":[{"ErrorEquals":["Lambda.ServiceException","Lambda.AWSLambdaException","Lambda.SdkClientException"],"IntervalSeconds":2,"MaxAttempts":6,"BackoffRate":2}],"Type":"Task","Resource":"arn:'
            - Ref: AWS::Partition
            - :states:::lambda:invoke","Parameters":{"FunctionName":"
            - Fn::GetAtt:
                - Func217E03A4
                - Arn
            - '","Payload":{"key1":[{"0":{"key2":{"key3":"value1"},"key4":[{"0":{"key5":{"key6":"value2"}}}]}}]}}}}}'

[srivastavr]

Hi, Any updates ?

[sakurai-ryo]

Hello @srivastavr, maybe this PR has solved the problem.
#26055