feat(codedeploy): support multiple load balancers for deployment groups #27607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p.ts Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
…up.test.ts Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
…up.test.ts Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
github-actions
bot
added
effort/small
github-actions
bot
added
the
beginning-contributor
|
|
|
Initial PR can be found here, creating a new PR from new feature branch. |
aws-cdk-automation
added
the
pr/needs-community-review
lpizzinidev
suggested changes
Oct 19, 2023
packages/aws-cdk-lib/aws-codedeploy/test/server/deployment-group.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
aws-cdk-automation
removed
the
pr/needs-community-review
…up.test.ts Co-authored-by: Luca Pizzini <lpizzini7@gmail.com>
lpizzinidev
approved these changes
Oct 20, 2023
|
@nicolastremblay1 |
nicolastremblay1
changed the title
Tested: `yarn run test -- '/Users/nictrem/Documents/aws-cdk/packages/aws-cdk-lib/aws-codedeploy/test/server/deployment-group.test.ts'`
aws-cdk-automation
added
the
pr/needs-maintainer-review
SankyRed
previously approved these changes
Oct 26, 2023
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mergify
bot
dismissed
SankyRed’s stale review
Pull request has been modified.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
SankyRed
approved these changes
Oct 27, 2023
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
mrgrain
pushed a commit
that referenced
this pull request
Nov 1, 2023
…ps (#27607) ### Summary This change adds multiple load balancer support for CodeDeploy deployment groups. There is a currently a loadBalancer field in the ServerDeploymentGroup, adding loadBalancers might be a good field to extend the functionality to create a deployment group with multiple load balancers. Closes #27407
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change adds multiple load balancer support for CodeDeploy deployment groups.
There is a currently a loadBalancer field in the ServerDeploymentGroup, adding loadBalancers might be a good field to extend the functionality to create a deployment group with multiple load balancers.
Closes #27407