Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-grafana: Missing pluginAdminEnabled property in CfnWorkspaceProps #28427

Closed
larskinder opened this issue Dec 19, 2023 · 5 comments
Closed
Labels
@aws-cdk/aws-cloudformation Related to AWS CloudFormation bug This issue is a bug. effort/small Small work item – less than a day of effort p2 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.

Comments

@larskinder
Copy link

Describe the bug

The CfnWorkspaceProps interface does not cover the CloudFormation property pluginAdminEnabled even so the cdk documentation states it does.

  1. https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_grafana.CfnWorkspaceProps.html#pluginadminenabled

Expected Behavior

CfnWorkspaceProps includes pluginAdminEnabled property and the property can be set to true or false.

Current Behavior

Setting the property leads to error
is not assignable to parameter of type  CfnWorkspaceProps  Object literal may only specify known properties, and  pluginAdminEnabled  does not exist in type  CfnWorkspaceProps

Reproduction Steps

Import grafana module and try to create either instance of CfnWorkspace directly or indirectly by creating object with type of CfnWorkspaceProps.

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.115.0 (build 58027ee)

Framework Version

No response

Node.js Version

v18.17.1

OS

Mac OS Ventura 13.6.1

Language

TypeScript

Language Version

No response

Other information

No response

@larskinder larskinder added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Dec 19, 2023
@github-actions github-actions bot added the @aws-cdk/aws-cloudformation Related to AWS CloudFormation label Dec 19, 2023
@khushail khushail added needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. effort/small Small work item – less than a day of effort p2 and removed needs-triage This issue or PR still needs to be triaged. labels Dec 19, 2023
@khushail
Copy link
Contributor

Hi @larskinder , thanks for reaching out. I have added the required labels to get the traction from cloudformation team but would also like to know if you are using Grafana 9 or later versions as I see this NOTE on cloudformation docs page.

@khushail khushail added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Dec 19, 2023
@larskinder
Copy link
Author

larskinder commented Dec 19, 2023

Hi, thanks for getting back to me.
Yeah, we set the version to grafanaVersion: '9.4',

If you check the Interface definition you will see that it is missing the property. The version should not matter when defining the resource, but on the creation of the resource. Or am I mistaken?

Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@larskinder
Copy link
Author

I closed the issue, as it was on me and thinking I use the newest cdk version, which I only set globally, but not in my package.json. 🤦
Sorry

@khushail
Copy link
Contributor

No Problem @larskinder . Thanks for reporting back and sharing what went wrong. Appreciate it.

@khushail khushail removed the needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. label Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-cloudformation Related to AWS CloudFormation bug This issue is a bug. effort/small Small work item – less than a day of effort p2 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.
Projects
None yet
Development

No branches or pull requests

2 participants