fix: revert deprecation of logRetention properties
#28934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bug
aws-cdk-automation
previously requested changes
Jan 31, 2024
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
mrgrain
added
pr-linter/exempt-test
|
Exempt from tests since this is a docs and annotations only change. I'm using |
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
4 tasks
mrgrain
changed the title
logRetention propertieslogRetention properties
mrgrain
changed the title
logRetention propertieslogRetention properties
aws-cdk-automation
added
the
pr/needs-maintainer-review
rix0rrr
requested changes
Jan 31, 2024
packages/aws-cdk-lib/custom-resources/lib/aws-custom-resource/aws-custom-resource.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk-lib/custom-resources/lib/provider-framework/provider.ts
Outdated
Show resolved
Hide resolved
rix0rrr
approved these changes
Jan 31, 2024
aws-cdk-automation
removed
the
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
SankyRed
pushed a commit
that referenced
this pull request
Feb 8, 2024
### Issue Closes #28919 ### Reason for this change In #28737 and #28783 we have deprecated various `logRetention` properties in favor of the new Logging Configuration feature for Lambda Functions. This new feature provides full control over the Lambda Function log group via the `logGroup` property. However Logging Configuration is not available yet for all regions. Particularly GovCloud and CN regions (at the time this issue was created). For customers in of these regions there is currently no clear migration path. We therefore revert the deprecation of previously deprecated properties. ### Description of changes Revert the deprecation of previously deprecated `logRetention` properties. Update documentation to be more explicit about the various options customers have. ### Description of how you validated changes Documentation & annotation change only. This is a partial revert of the PRs linked about, with minor documentation updates. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes #28919
Reason for this change
In #28737 and #28783 we have deprecated various
logRetentionproperties in favor of the new Logging Configuration feature for Lambda Functions. This new feature provides full control over the Lambda Function log group via thelogGroupproperty.However Logging Configuration is not available yet for all regions. Particularly GovCloud and CN regions (at the time this issue was created). For customers in of these regions there is currently no clear migration path.
We therefore revert the deprecation of previously deprecated properties.
Description of changes
Revert the deprecation of previously deprecated
logRetentionproperties.Update documentation to be more explicit about the various options customers have.
Description of how you validated changes
Documentation & annotation change only. This is a partial revert of the PRs linked about, with minor documentation updates.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license