Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(elasticloadbalancingv2): allow alb slow start duration of 0 seconds #29445

Merged
merged 3 commits into from Mar 18, 2024
Merged

fix(elasticloadbalancingv2): allow alb slow start duration of 0 seconds #29445

merged 3 commits into from Mar 18, 2024

Conversation

msambol
Copy link
Contributor

@msambol msambol commented Mar 11, 2024

Closes #29437.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p1 star-contributor [Pilot] contributed between 25-49 PRs to the CDK labels Mar 11, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team March 11, 2024 18:26
aws-cdk-automation
aws-cdk-automation previously requested changes Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@msambol
Copy link
Contributor Author

msambol commented Mar 11, 2024

Exemption request: Unit test should be fine here for this fix.

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Mar 11, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 11, 2024
godwingrs22
godwingrs22 reviewed Mar 14, 2024
View reviewed changes
Copy link
Member

@godwingrs22 godwingrs22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a minor comment.

packages/aws-cdk-lib/aws-elasticloadbalancingv2/lib/alb/application-target-group.ts
@@ -330,8 +330,9 @@ export class ApplicationTargetGroup extends TargetGroupBase implements IApplicat

if (props) {
if (props.slowStart !== undefined) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if we need to handle where slowStart is not specified/undefined, to explicity set slow_start.duration_seconds attribute as default 0. since I saw in the issue reported, it was mentioned if it is not specified, it deploys successfully but Target Group resource still has it enabled(if previously enabled).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm.. I think if they want it disabled they should have to set it explicitly ? My concern is if we set to 0, it will cause changes with stacks that are already deployed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah seems valid. This looks good to me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks!

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 15, 2024
@msambol
Copy link
Contributor Author

msambol commented Mar 15, 2024

@godwingrs22 Do you mind merging main into this?

@gracelu0 gracelu0 added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Mar 18, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 18, 2024 01:26

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 94b21c7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 18, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit cf2351b into aws:main Mar 18, 2024
12 of 13 checks passed
@msambol msambol deleted the 29437 branch March 18, 2024 01:47
@github-actions github-actions bot mentioned this pull request Mar 18, 2024
Closed
ahammond pushed a commit to ahammond/aws-cdk that referenced this pull request Mar 26, 2024
@msambol @ahammond
fix(elasticloadbalancingv2): allow alb slow start duration of 0 secon…
72d2aff 
…ds (aws#29445)

Closes aws#29437.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions github-actions bot mentioned this pull request Apr 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godwingrs22 godwingrs22 godwingrs22 approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p1 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[aws_elasticloadbalancingv2]: Target Group 'slowStart' option can't be disabled
4 participants
@msambol @aws-cdk-automation @godwingrs22 @gracelu0