Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDKv3-04: Update @aws-cdk/cloudformation-diff #29840

Closed
Tracked by #29694
TheRealAmazonKendra opened this issue Apr 15, 2024 · 2 comments
Closed
Tracked by #29694

SDKv3-04: Update @aws-cdk/cloudformation-diff #29840

TheRealAmazonKendra opened this issue Apr 15, 2024 · 2 comments
Assignees

Comments

@TheRealAmazonKendra
Copy link
Contributor

Context

The AWS SDK V2 is being deprecated. We need to remove all uses of it from the CDK.

Task Description

The CloudFormation namespace is used in diff-template.ts. Remove this and update aws-cdk to also have the correct namespace when this is used.

Open Questions

  1. aws-cdk must also be upgraded to make this change. Will it cause conflicts/issues to upgrade parts of aws-cdk at a time? If so, this will have to be done with several other tasks in one fell swoop. (I don't think this is the case, but it's worth mentioning)

Acceptance Criteria

  1. Remove use of the v2 namespace in all locations.
  2. All tests (unit and integ) still are passing after these changes.
@TheRealAmazonKendra
Copy link
Contributor Author

#29730

Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant