Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDKv3-06: Update cdk-assets #29841

Open
Tracked by #29694
TheRealAmazonKendra opened this issue Apr 15, 2024 · 0 comments
Open
Tracked by #29694

SDKv3-06: Update cdk-assets #29841

TheRealAmazonKendra opened this issue Apr 15, 2024 · 0 comments
Assignees
Labels
in-progress This issue is being actively worked on.

Comments

@TheRealAmazonKendra
Copy link
Contributor

Context

The AWS SDK V2 is being deprecated. We need to remove all uses of it from the CDK.

Task Description

Update cdk-assets to use sdkv3 and update the locations in aws-cdk required so that the types used are the same.

Known uses:

  • lib/aws.ts: this generates a default client that is used extensively elsewhere in this package and in aws-cdk
  • lib/private/handlers/container-image.ts: creates an ECR client that is used in a few locations
  • test/mock-aws.ts

Acceptance Criteria

  1. sdkv2 is completely removed from the cdk-assets package
  2. Updates are made where needed in aws-cdk to not cause type confilcts
  3. All tests (unit and integ) pass after the change has been made.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-progress This issue is being actively worked on.
Projects
None yet
Development

No branches or pull requests

1 participant