Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-events): IApiDestination is missing grantInvokeApiDestination #30386

Open
1 of 2 tasks
WtfJoke opened this issue May 30, 2024 · 1 comment
Open
1 of 2 tasks

(aws-events): IApiDestination is missing grantInvokeApiDestination #30386

WtfJoke opened this issue May 30, 2024 · 1 comment
Labels
@aws-cdk/aws-events Related to CloudWatch Events effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@WtfJoke
Copy link
Contributor

WtfJoke commented May 30, 2024

Describe the feature

The IApiDestination provides currently no grant* method. This makes it harder/more cumbersome to invoke an API Destination from a given construct.

The permission needed to invoke an API Destination: events:InvokeApiDestination

Use Case

I was building the solution for #29386 and when I wrote the grantPush functionality in there I was missing the grantInvokeApiDestination method of IApiDestination

Proposed Solution

Add method grantInvokeApiDestination to IApiDestination and implement it in ApiDestination.

Method signature could look like that:
public grantInvokeApiDestination(grantee: iam.IGrantable): iam.Grant.

It will allow the action events:InvokeApiDestination for the grantee.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.136.0

Environment details (OS name and version, etc.)

windows 11

@WtfJoke WtfJoke added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 30, 2024
@github-actions github-actions bot added the @aws-cdk/aws-events Related to CloudWatch Events label May 30, 2024
@khushail khushail added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels May 30, 2024
@khushail khushail self-assigned this May 30, 2024
@khushail
Copy link
Contributor

@WtfJoke ,that makes sense. Please feel free to submit a PR!
Thanks!

@khushail khushail added p2 effort/small Small work item – less than a day of effort labels May 30, 2024
@khushail khushail removed their assignment May 30, 2024
@khushail khushail removed the investigating This issue is being investigated and/or work is in progress to resolve the issue. label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-events Related to CloudWatch Events effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

No branches or pull requests

2 participants