Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloudfront): force compress true default value #3359

Merged
merged 10 commits into from
Sep 18, 2019

Conversation

nmussy
Copy link
Contributor

@nmussy nmussy commented Jul 19, 2019

Fixes #3307


Please read the contribution guidelines and follow the pull-request checklist.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

* CloudFormation defaults the value to false
@nmussy nmussy requested a review from a team as a code owner July 19, 2019 14:00
eladb
eladb previously approved these changes Jul 21, 2019
@NGL321 NGL321 self-assigned this Aug 1, 2019
@nmussy
Copy link
Contributor Author

nmussy commented Aug 16, 2019

@NGL321 Anything stopping this from being merged?

@nmussy
Copy link
Contributor Author

nmussy commented Sep 17, 2019

Not sure why there's no movement on this PR. The JSDoc still indicates a true default:

* @default true
*/
readonly compress?: boolean;

@mergify
Copy link
Contributor

mergify bot commented Sep 17, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist
:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@mergify mergify bot dismissed eladb’s stale review September 17, 2019 07:36

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@nmussy
Copy link
Contributor Author

nmussy commented Sep 18, 2019

My apologies about that previous commit, I was experimenting with lerna and accidentally pushed to this branch. It seems that involved a lot of reviewers. Sorry about that everyone!

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@rix0rrr rix0rrr merged commit 364fd56 into aws:master Sep 18, 2019
@nmussy
Copy link
Contributor Author

nmussy commented Sep 18, 2019

Thanks @rix0rrr 👍

@nmussy nmussy deleted the fix-default-compress branch September 18, 2019 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CloudFront: Behavior compress is not defaulted to true
5 participants