-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cloudfront): force compress true default value #3359
Conversation
* CloudFormation defaults the value to false
@NGL321 Anything stopping this from being merged? |
Not sure why there's no movement on this PR. The JSDoc still indicates a true default: aws-cdk/packages/@aws-cdk/aws-cloudfront/lib/web_distribution.ts Lines 274 to 276 in 47e5c13
|
Thanks so much for taking the time to contribute to the AWS CDK ❤️ We will shortly assign someone to review this pull request and help get it
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
6c9cc9f
to
3fea6e7
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
My apologies about that previous commit, I was experimenting with lerna and accidentally pushed to this branch. It seems that involved a lot of reviewers. Sorry about that everyone! |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thanks @rix0rrr 👍 |
Fixes #3307
Please read the contribution guidelines and follow the pull-request checklist.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license