Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cloudwatch): dashboardName validation #3382

Merged
merged 7 commits into from
Jul 23, 2019

Conversation

nmussy
Copy link
Contributor

@nmussy nmussy commented Jul 22, 2019

Fixes #2976


Please read the contribution guidelines and follow the pull-request checklist.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@nmussy nmussy requested a review from a team as a code owner July 22, 2019 12:33
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update commit message and explain what you are doing

packages/@aws-cdk/aws-cloudwatch/lib/dashboard.ts Outdated Show resolved Hide resolved
@nmussy nmussy closed this Jul 22, 2019
@nmussy nmussy deleted the feat-cloudwatch-dashboard-name-validation branch July 22, 2019 13:48
@nmussy nmussy restored the feat-cloudwatch-dashboard-name-validation branch July 22, 2019 13:48
@nmussy nmussy reopened this Jul 22, 2019
@eladb eladb merged commit f53f845 into aws:master Jul 23, 2019
@nmussy nmussy deleted the feat-cloudwatch-dashboard-name-validation branch July 23, 2019 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add string validation for CloudFormation DashboardName
2 participants