Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws-codebuild): support pull_request_merged eventaction type #3575

Merged
merged 4 commits into from
Aug 7, 2019
Merged

feat(aws-codebuild): support pull_request_merged eventaction type #3575

merged 4 commits into from
Aug 7, 2019

Conversation

mbruning24
Copy link
Contributor

Closes #3557

Added PULL_REQUEST_MERGED type to the EventAction Enum for use in source webhook filter groups


Please read the contribution guidelines and follow the pull-request checklist.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…ed PULL_REQUEST_MERGED type to the EventAction Enum for use in source webhook filter groups closes #3557
@skinny85 skinny85 self-assigned this Aug 7, 2019
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! One tiny comment :)

@@ -581,6 +581,7 @@ export = {
codebuild.FilterGroup.inEventOf(
codebuild.EventAction.PULL_REQUEST_CREATED,
codebuild.EventAction.PULL_REQUEST_UPDATED,
codebuild.EventAction.PULL_REQUEST_MERGED
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave the trailing comma here (look how beautiful the diff is because of it 😊)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trailing comma added, committed, and pushed,

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what you did there... 😉

Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mergify mergify bot merged commit 5d4a275 into aws:master Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support PULL_REQUEST_MERGED EventAction in aws-codebuild module
2 participants