-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aws-codebuild): support pull_request_merged eventaction type #3575
feat(aws-codebuild): support pull_request_merged eventaction type #3575
Conversation
…ed PULL_REQUEST_MERGED type to the EventAction Enum for use in source webhook filter groups closes #3557
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! One tiny comment :)
@@ -581,6 +581,7 @@ export = { | |||
codebuild.FilterGroup.inEventOf( | |||
codebuild.EventAction.PULL_REQUEST_CREATED, | |||
codebuild.EventAction.PULL_REQUEST_UPDATED, | |||
codebuild.EventAction.PULL_REQUEST_MERGED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leave the trailing comma here (look how beautiful the diff is because of it 😊)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trailing comma added, committed, and pushed,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see what you did there... 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Closes #3557
Added PULL_REQUEST_MERGED type to the EventAction Enum for use in source webhook filter groups
Please read the contribution guidelines and follow the pull-request checklist.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license