Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kms): append aliasName only after first #3659

Merged
merged 2 commits into from
Aug 14, 2019
Merged

Conversation

nmussy
Copy link
Contributor

@nmussy nmussy commented Aug 14, 2019

Fixes #3652


Please read the contribution guidelines and follow the pull-request checklist.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@nmussy
Copy link
Contributor Author

nmussy commented Aug 14, 2019

It'd be great if this was shipped as soon as possible in a patch release, as this breaks 1.3.0 stacks containing KMS key aliases.

packages/@aws-cdk/aws-kms/lib/key.ts Show resolved Hide resolved
@mergify mergify bot merged commit 77671ad into aws:master Aug 14, 2019
@nmussy nmussy deleted the 3652 branch August 15, 2019 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KMS: addAlias 1.3 ->1.4 upgrade error
2 participants