Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ecs): add additional log drivers #3762

Merged
merged 87 commits into from
Sep 13, 2019
Merged

feat(ecs): add additional log drivers #3762

merged 87 commits into from
Sep 13, 2019

Conversation

wulfmann
Copy link
Contributor

@wulfmann wulfmann commented Aug 22, 2019 •
edited

Rationale : Adds journald LogDriver to ECS.

Issues: closes #3761

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mergify
Copy link
Contributor

mergify bot commented Aug 22, 2019

Pull Request Checklist

  • Testing
  • Unit test added (prefer to add a new test rather than modify existing tests)
  • CLI change? Re-run/add CLI integration tests
  • Documentation
  • Inline docs: make sure all public APIs are documented (copy & paste from official AWS docs)
  • README: update module README
  • Design: for significant features, follow the design process
  • Title uses the format type(scope): text
  • Type: fix, feat, refactor go into CHANGELOG, chore is hidden
  • Scope: name of the module without the aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
  • Style: use all lower-case, do not end with a period
  • Description
  • Rationale: describe rationale of change and approach taken
  • Issues: Indicate issues fixed via: fixes #xxx or closes #xxx
  • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Sensitive Modules (requires 2 PR approvers)
  • IAM document library (in @aws-cdk/aws-iam)
  • EC2 security groups and ACLs (in @aws-cdk/aws-ec2)
  • Grant APIs (if not based on official documentation with a reference)

@wulfmann wulfmann changed the title Add journald LogDriver feat: Add journald LogDriver Aug 22, 2019
@wulfmann wulfmann changed the title feat: Add journald LogDriver feat(ecs): Add journald LogDriver Aug 22, 2019
@wulfmann
Copy link
Contributor Author

@eladb It wasn't totally clear to me if there was a different way to implement the journald driver, but if there is feel free to let me know and we can close this PR and related issue.

@wulfmann wulfmann changed the title feat(ecs): Add journald LogDriver feat(ecs): dd journald log-driver Aug 22, 2019
@wulfmann wulfmann changed the title feat(ecs): dd journald log-driver feat(ecs): adds journald log-driver Aug 22, 2019
@mergify
Copy link
Contributor

mergify bot commented Aug 22, 2019

Codebuild (Continuous Integration) build failed for current commits. Please check log and resolve before PR is merged.

@mergify
Copy link
Contributor

mergify bot commented Aug 22, 2019

Codebuild (Continuous Integration) build failed for current commits. Please check log and resolve before PR is merged.

@mergify
Copy link
Contributor

mergify bot commented Aug 22, 2019

Codebuild (Continuous Integration) build failed for current commits. Please check log and resolve before PR is merged.

@mergify
Copy link
Contributor

mergify bot commented Aug 22, 2019

Codebuild (Continuous Integration) build failed for current commits. Please check log and resolve before PR is merged.

@mergify
Copy link
Contributor

mergify bot commented Aug 22, 2019

Codebuild (Continuous Integration) build failed for current commits. Please check log and resolve before PR is merged.

@mergify
Copy link
Contributor

mergify bot commented Aug 22, 2019

Codebuild (Continuous Integration) build failed for current commits. Please check log and resolve before PR is merged.

@mergify
Copy link
Contributor

mergify bot commented Aug 23, 2019

Codebuild (Continuous Integration) build failed for current commits. Please check log and resolve before PR is merged.

@mergify
Copy link
Contributor

mergify bot commented Aug 23, 2019

Codebuild (Continuous Integration) build failed for current commits. Please check log and resolve before PR is merged.

@mergify
Copy link
Contributor

mergify bot commented Aug 23, 2019

Codebuild (Continuous Integration) build failed for current commits. Please check log and resolve before PR is merged.

@mergify
Copy link
Contributor

mergify bot commented Aug 23, 2019

Codebuild (Continuous Integration) build failed for current commits. Please check log and resolve before PR is merged.

@wulfmann
Copy link
Contributor Author

wulfmann commented Sep 5, 2019

I'm not entirely sure the travis check is failing because of my changes. I think it's related to something else.

@mergify
Copy link
Contributor

mergify bot commented Sep 6, 2019

Codebuild (Continuous Integration) build failed for current commits. Please check log and resolve before PR is merged.

@mergify
Copy link
Contributor

mergify bot commented Sep 6, 2019

Codebuild (Continuous Integration) build failed for current commits. Please check log and resolve before PR is merged.

rix0rrr
rix0rrr reviewed Sep 9, 2019
View reviewed changes
packages/@aws-cdk/aws-ecs/lib/log-drivers/fluentd-log-driver.ts Outdated
'fluentd-address': this.props.address,
'fluentd-async-connect': this.props.asyncConnect,
'fluentd-buffer-limit': this.props.bufferLimit,
'fluentd-retry-wait': this.props.retryWait,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, you can't just put a Duration into a response object. You'll have to convert it to seconds/milliseconds whatever using the right function on the Duration object.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea i saw that in the error. i am nearly done with an update to fix this.

@mergify
Copy link
Contributor

mergify bot commented Sep 9, 2019

Continuous integration build failed

@mergify
Copy link
Contributor

mergify bot commented Sep 13, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@rix0rrr rix0rrr merged commit f308f1d into aws:master Sep 13, 2019
rix0rrr
rix0rrr reviewed Sep 13, 2019
View reviewed changes
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve, but manually merged to preserve the commit message. do-not-merge is not working ATM.

@wulfmann wulfmann deleted the journald-log-driver branch September 13, 2019 12:43
@NGL321 NGL321 mentioned this pull request Oct 4, 2019
Closed
@kaizencc kaizencc mentioned this pull request Oct 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr left review comments

Assignees

@rix0rrr rix0rrr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add journald Log Driver to ECS
5 participants
@wulfmann @aws-cdk-automation @rix0rrr @NGL321 @piradeepk