Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom dockerfile names #3829

Closed
2 tasks
jeshan opened this issue Aug 28, 2019 · 2 comments 路 Fixed by #5652
Closed
2 tasks

Support custom dockerfile names #3829

jeshan opened this issue Aug 28, 2019 · 2 comments 路 Fixed by #5652
Assignees
Labels
@aws-cdk/assets Related to the @aws-cdk/assets package effort/small Small work item 鈥撀爈ess than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md

Comments

@jeshan
Copy link

jeshan commented Aug 28, 2019

馃殌 Feature Request

General Information

  • 馃憢 I may be able to implement this feature request
  • 鈿狅笍 This feature might incur a breaking change

Description

I have a project where multiple dockerfiles have the same build context. In this case, it would be nice to be able to pass in the dockerfile name. (I'm taking about the -f parameter in docker build)

Proposed Solution

In the prepareContainerAsset method,

const baseCommand = [
'docker', 'build',
...buildArgs,
'--tag', latest,
contextPath
];

it's missing the -f parameter which could default to something like $path/Dockerfile.

Environment

  • CDK CLI Version: 1.6.0
  • Module Version:
  • OS: all
  • Language: all

Other information

Similar feature request: #3342 where a custom build context is being requested.

@jeshan jeshan added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 28, 2019
@SomayaB SomayaB added the package/tools Related to AWS CDK Tools or CLI label Sep 6, 2019
@rix0rrr
Copy link
Contributor

rix0rrr commented Sep 9, 2019

I believe this has been requested before already.

@rix0rrr rix0rrr removed the needs-triage This issue or PR still needs to be triaged. label Sep 9, 2019
@eladb eladb assigned eladb and unassigned rix0rrr Sep 9, 2019
@eladb eladb added @aws-cdk/assets Related to the @aws-cdk/assets package and removed package/tools Related to AWS CDK Tools or CLI labels Sep 9, 2019
@eladb
Copy link
Contributor

eladb commented Sep 9, 2019

@SomayaB this was misclassified as package/tools instead of package/assets.

@rix0rrr rix0rrr added the good first issue Related to contributions. See CONTRIBUTING.md label Dec 2, 2019
@iliapolo iliapolo assigned iliapolo and unassigned eladb Jan 5, 2020
@mergify mergify bot closed this as completed in #5652 Jan 6, 2020
@iliapolo iliapolo added the effort/small Small work item 鈥撀爈ess than a day of effort label Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/assets Related to the @aws-cdk/assets package effort/small Small work item 鈥撀爈ess than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants