Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s3-deployment): CallerReference has to be unique #3880

Merged
merged 2 commits into from
Aug 30, 2019
Merged

fix(s3-deployment): CallerReference has to be unique #3880

merged 2 commits into from
Aug 30, 2019

Conversation

hoegertn
Copy link
Contributor

@hoegertn hoegertn commented Aug 30, 2019

fixes #3878

CallerReference has to be unique per invalidation but was set to a fix value for every deployment.

This PR fixes this.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mergify
Copy link
Contributor

mergify bot commented Aug 30, 2019

Pull Request Checklist

  • Testing
  • Unit test added (prefer to add a new test rather than modify existing tests)
  • CLI change? Re-run/add CLI integration tests
  • Documentation
  • Inline docs: make sure all public APIs are documented (copy & paste from official AWS docs)
  • README: update module README
  • Design: for significant features, follow the design process
  • Title uses the format type(scope): text
  • Type: fix, feat, refactor go into CHANGELOG, chore is hidden
  • Scope: name of the module without the aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
  • Style: use all lower-case, do not end with a period
  • Description
  • Rationale: describe rationale of change and approach taken
  • Issues: Indicate issues fixed via: fixes #xxx or closes #xxx
  • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Sensitive Modules (requires 2 PR approvers)
  • IAM document library (in @aws-cdk/aws-iam)
  • EC2 security groups and ACLs (in @aws-cdk/aws-ec2)
  • Grant APIs (if not based on official documentation with a reference)

Copy link
Contributor

@shivlaks shivlaks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do the tests for this Lambda need to be updated as well?

@mergify
Copy link
Contributor

mergify bot commented Aug 30, 2019

Codebuild (Continuous Integration) build failed for current commits. Please check log and resolve before PR is merged.

@hoegertn
Copy link
Contributor Author

do the tests for this Lambda need to be updated as well?

Good catch. I should be awake when creating PRs ;-)

@mergify
Copy link
Contributor

mergify bot commented Aug 30, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot merged commit 16eb658 into aws:master Aug 30, 2019
@harmohan-a
Copy link

let me know when its released. i'll test it then

@eladb
Copy link
Contributor

eladb commented Sep 3, 2019

Can you please update the PR description with details on why this needed to change? What was wrong with the previous implementation, what the service requires and how this fixes it. Please try to follow the PR checklist above.

@hoegertn hoegertn deleted the fix-invalidation branch September 27, 2019 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalidation on cloudfront fails using s3.BucketDeployment on updates
4 participants