Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to CloudFormation specification 6.0.0 #3942

Merged
merged 9 commits into from
Sep 5, 2019

Conversation

skinny85
Copy link
Contributor

@skinny85 skinny85 commented Sep 4, 2019


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mergify
Copy link
Contributor

mergify bot commented Sep 4, 2019

Pull Request Checklist

  • Testing
  • Unit test added (prefer to add a new test rather than modify existing tests)
  • CLI change? Re-run/add CLI integration tests
  • Documentation
  • Inline docs: make sure all public APIs are documented (copy & paste from official AWS docs)
  • README: update module README
  • Design: for significant features, follow the design process
  • Title uses the format type(scope): text
  • Type: fix, feat, refactor go into CHANGELOG, chore is hidden
  • Scope: name of the module without the aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
  • Style: use all lower-case, do not end with a period
  • Description
  • Rationale: describe rationale of change and approach taken
  • Issues: Indicate issues fixed via: fixes #xxx or closes #xxx
  • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Sensitive Modules (requires 2 PR approvers)
  • IAM document library (in @aws-cdk/aws-iam)
  • EC2 security groups and ACLs (in @aws-cdk/aws-ec2)
  • Grant APIs (if not based on official documentation with a reference)

@mergify
Copy link
Contributor

mergify bot commented Sep 4, 2019

Codebuild (Continuous Integration) build failed for current commits. Please check log and resolve before PR is merged.

@skinny85
Copy link
Contributor Author

skinny85 commented Sep 4, 2019

Build failed with:

@aws-cdk/aws-ec2: Verifying integ.instance.js against integ.instance.expected.json ... CHANGED.
@aws-cdk/aws-ec2: Resources
@aws-cdk/aws-ec2: [~] AWS::IAM::Role InstanceInstanceRoleE9785DE5 
@aws-cdk/aws-ec2:  └─ [+] Tags
@aws-cdk/aws-ec2:      └─ [{"Key":"Name","Value":"TestStack/Instance"}]

This is fascinating... how can the CFN spec change the tags of existing resources....?

@mergify
Copy link
Contributor

mergify bot commented Sep 4, 2019

Codebuild (Continuous Integration) build failed for current commits. Please check log and resolve before PR is merged.

@mergify
Copy link
Contributor

mergify bot commented Sep 4, 2019

Codebuild (Continuous Integration) build failed for current commits. Please check log and resolve before PR is merged.

@mergify
Copy link
Contributor

mergify bot commented Sep 5, 2019

Codebuild (Continuous Integration) build failed for current commits. Please check log and resolve before PR is merged.

@mergify
Copy link
Contributor

mergify bot commented Sep 5, 2019

Codebuild (Continuous Integration) build failed for current commits. Please check log and resolve before PR is merged.

@mergify
Copy link
Contributor

mergify bot commented Sep 5, 2019

Codebuild (Continuous Integration) build failed for current commits. Please check log and resolve before PR is merged.

Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug update with implications on user stacks that used tags (IAM roles are now taggable).

@mergify
Copy link
Contributor

mergify bot commented Sep 5, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot merged commit 27de0a0 into master Sep 5, 2019
@mergify mergify bot deleted the adamruka/upgrade-cfn-spec branch September 5, 2019 05:09
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants