Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(events): remove policy statement from CF template when using AwsApi #4037

Merged
merged 4 commits into from
Sep 11, 2019

Conversation

jogold
Copy link
Contributor

@jogold jogold commented Sep 11, 2019

All props of the AwsApi target were passed as event input, unnecessarily polluting the
CloudFormation template.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

All props of the `AwsApi` target were passed as event input, unnecessarily polluting the
CloudFormation template.
@mergify
Copy link
Contributor

mergify bot commented Sep 11, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist
:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@mergify
Copy link
Contributor

mergify bot commented Sep 11, 2019

Continuous integration build failed

@mergify
Copy link
Contributor

mergify bot commented Sep 11, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot merged commit 2e67c2d into aws:master Sep 11, 2019
@jogold jogold deleted the aws-api-target-clean branch September 11, 2019 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants