feat(s3-deployment): allow multiple Sources for single Deployment #4105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much for taking the time to contribute to the AWS CDK ❤️ We will shortly assign someone to review this pull request and help get it
|
CaerusKaru
force-pushed
the
adam/s3-mult
branch
from
e4ee35c
to
8759815
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
CaerusKaru
force-pushed
the
adam/s3-mult
branch
from
fcb76af
to
aa66eaf
Compare
eladb
reviewed
Sep 18, 2019
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
CaerusKaru
force-pushed
the
adam/s3-mult
branch
from
aa66eaf
to
91248ed
Compare
eladb
reviewed
Sep 18, 2019
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
eladb
reviewed
Sep 18, 2019
packages/@aws-cdk/aws-s3-deployment/test/integ.bucket-deployment-cloudfront.expected.json
Outdated
Show resolved
Hide resolved
CaerusKaru
force-pushed
the
adam/s3-mult
branch
2 times, most recently
from
56e8691
to
229154f
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
eladb
previously requested changes
Sep 19, 2019
added 4 commits
September 19, 2019 10:48
In some cases, a user may want to inject other sources into a deployment. For instance, storing JavaScript bundles in one directory and images in another, then combining them in a single bucket for CloudFront distributions. * All sources will be fetched and consolidated into one directory before being zipped as normal prior to deployment BREAKING CHANGE: * Property `source` is now `sources` and is a `Source` array
CaerusKaru
force-pushed
the
adam/s3-mult
branch
from
229154f
to
d2336b1
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
eladb
approved these changes
Sep 19, 2019
|
Thank you for contributing! Your pull request is now being automatically merged. |
eladb
pushed a commit
that referenced
this pull request
Sep 23, 2019
) * feat(s3-deployment): allow multiple Sources for single Deployment In some cases, a user may want to inject other sources into a deployment. For instance, storing JavaScript bundles in one directory and images in another, then combining them in a single bucket for CloudFront distributions. * All sources will be fetched and consolidated into one directory before being zipped as normal prior to deployment BREAKING CHANGE: * Property `source` is now `sources` and is a `Source` array * fixup! feat(s3-deployment): allow multiple Sources for single Deployment * fixup! feat(s3-deployment): allow multiple Sources for single Deployment * fixup! feat(s3-deployment): allow multiple Sources for single Deployment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, a user may want to inject other sources into a
deployment. For instance, storing JavaScript bundles in one
directory and images in another, then combining them in a
single bucket for CloudFront distributions.
before being zipped as normal prior to deployment
BREAKING CHANGE:
sourceis nowsourcesand is aSourcearrayBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license