Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ses-actions): move SES rule actions to separate package #4163

Merged
merged 8 commits into from
Sep 27, 2019
Merged

feat(ses-actions): move SES rule actions to separate package #4163

merged 8 commits into from
Sep 27, 2019

Conversation

jogold
Copy link
Contributor

@jogold jogold commented Sep 19, 2019 •
edited

Move cross-service integrations for receipt rule actions to their own package in accordance with
the CDK guidelines.

Closes #3726

BREAKING CHANGE: adding an action to a receipt rule now requires an integration
object from the @aws-cdk/aws-ses-actions package.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mergify
Copy link
Contributor

mergify bot commented Sep 19, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jogold
feat(ses-actions): move SES rule actions to separate package
dff23c0 
Move cross-service integrations for receipt rule actions to their own package in accordance with
the CDK guidelines.

Closes aws#3726

BREAKING CHANGE: adding an action to a receipt rule now requires an integration
object from the `@aws-cdk/aws-ses-actions` package.
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

shivlaks
shivlaks reviewed Sep 26, 2019
View reviewed changes
packages/@aws-cdk/aws-ses-actions/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-ses-actions/README.md Show resolved Hide resolved
packages/@aws-cdk/aws-ses/test/integ.receipt.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-ses/README.md Outdated
```
When using `addRule`, the new rule is added after the last added rule unless `after` is specified.

[More actions](test/integ.receipt.ts)
Actions can be found in the `@aws-cdk/aws-ses-actions` package.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome to have examples get updated! feels like this should come ahead of code samples that use actions though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean here exactly, can you clarify? The integ tests for actions are now in aws-ses-actions and you want to point to examples there?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, the snippets of code that reference actions don't include the import of the actions package, so it'd be good to move this before the code samples :)

packages/@aws-cdk/aws-ses/lib/receipt-rule.ts Show resolved Hide resolved
packages/@aws-cdk/aws-ses-actions/lib/sns.ts Outdated Show resolved Hide resolved
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

shivlaks
shivlaks previously approved these changes Sep 27, 2019
View reviewed changes
@jogold
Copy link
Contributor Author

jogold commented Sep 27, 2019 •
edited

@shivlaks are you sure mergify will correctly commit with the BREAKING CHANGE in the footer? If not, it won't be correctly picked up in the CHANGELOG. "Manual" squashing maybe here?

@shivlaks shivlaks added the pr/do-not-merge This PR should not be merged at this time. label Sep 27, 2019
@shivlaks
Copy link
Contributor

@shivlaks are you sure mergify will correctly commit with the BREAKING CHANGE in the footer? If not, it won't be correctly picked up in the CHANGELOG. "Manual" squashing maybe here?

@jogold good call, let me check and take care of it. temporarily added a do-not-merge so mergify doesn't surprise us in an unexpected way :)

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot dismissed shivlaks’s stale review September 27, 2019 08:30

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@shivlaks shivlaks removed the pr/do-not-merge This PR should not be merged at this time. label Sep 27, 2019
@shivlaks shivlaks merged commit a9fef66 into aws:master Sep 27, 2019
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jogold jogold deleted the ses-actions branch September 27, 2019 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivlaks shivlaks shivlaks approved these changes

Assignees

@shivlaks shivlaks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when creating SES Rule with s3 action from existing rule set
3 participants
@jogold @aws-cdk-automation @shivlaks