Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ssm): allow specifying encryption key #4511

Merged
merged 3 commits into from
Oct 16, 2019
Merged

fix(ssm): allow specifying encryption key #4511

merged 3 commits into from
Oct 16, 2019

Conversation

jogold
Copy link
Contributor

@jogold jogold commented Oct 15, 2019

This is required when referencing a secure string encrypted using a
customer-managed CMK.

Closes #4498

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@jogold
fix(ssm): allow specifying encryption key
1b8f43c 
This is required when referencing a secure string encrypted using a
customer-managed CMK.

Closes aws#4498
@jogold jogold requested a review from eladb as a code owner October 15, 2019 08:38
@mergify
Copy link
Contributor

mergify bot commented Oct 15, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

eladb
eladb previously approved these changes Oct 16, 2019
View reviewed changes
@mergify
Copy link
Contributor

mergify bot commented Oct 16, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot dismissed eladb’s stale review October 16, 2019 12:24

Pull request has been modified.

@jogold
Copy link
Contributor Author

jogold commented Oct 16, 2019

Had to fix the conflict in package.json

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 02a447f into aws:master Oct 16, 2019
@jogold jogold deleted the ssm-encryption-key branch October 24, 2019 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb approved these changes

Assignees

@eladb eladb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Passing SecureString parameters to ECS Container as secrets is missing required KMS policies
3 participants
@jogold @aws-cdk-automation @eladb