Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow different image for aws_cdk.aws_ec2.BastionHostLinux #4730

Closed
1 of 2 tasks
nzspambot opened this issue Oct 28, 2019 · 3 comments
Closed
1 of 2 tasks

allow different image for aws_cdk.aws_ec2.BastionHostLinux #4730

nzspambot opened this issue Oct 28, 2019 · 3 comments
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@nzspambot
Copy link

Currently aws_cdk.aws_ec2.BastionHostLinux is hardcoded for:

Parameters:
  SsmParameterValueawsserviceamiamazonlinuxlatestamzn2amihvmx8664gp2C96584B6F00A464EAD1953AFF4B05118Parameter:
    Type: AWS::SSM::Parameter::Value<AWS::EC2::Image::Id>
    Default: /aws/service/ami-amazon-linux-latest/amzn2-ami-hvm-x86_64-gp2

it would be nice to be able to provide your own AWS::SSM::Parameter::Value as we build per-hardened AMIs

Use Case

we build per-hardened updated AMIs with security tools installed which we would use

Proposed Solution

Add a parameter such as ssm_parameter to allow this to be used

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@nzspambot nzspambot added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 28, 2019
@SomayaB SomayaB added the @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud label Oct 28, 2019
@nzspambot
Copy link
Author

One thing I forgot to think about 🙄 was how to cater for the user data given say of the ami is not amazon linux?

@rix0rrr rix0rrr added the good first issue Related to contributions. See CONTRIBUTING.md label Dec 2, 2019
@rix0rrr rix0rrr added the effort/small Small work item – less than a day of effort label Jan 23, 2020
@SomayaB SomayaB removed the needs-triage This issue or PR still needs to be triaged. label Mar 4, 2020
@rix0rrr rix0rrr added the p2 label Aug 12, 2020
@rix0rrr rix0rrr removed their assignment Jun 3, 2021
@cokia
Copy link
Contributor

cokia commented Oct 11, 2021

readonly machineImage?: IMachineImage;

I think this is already defined.

However, the test code for this has been confirmed to not exist, so it remains to be seen whether it works.

Do we need a test code for this?

@github-actions
Copy link

This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
Development

No branches or pull requests

4 participants