Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade all uses of node8.10 lambda runtime to node10.x #5075

Merged
merged 5 commits into from
Nov 18, 2019

Conversation

nija-at
Copy link
Contributor

@nija-at nija-at commented Nov 18, 2019

Upgrade all internal uses of Node8.10 lambda runtime to Node10.X.

This includes all exported constructs that contain a lambda function within them.

Update NODE_10_X runtime to allow inline code in CloudFormation, per
aws-cloudformation/cloudformation-coverage-roadmap#80.

Shout out to @nmussy who got this most of the way (#4655)

close #4653, close #4642


Additional Testing


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Update NODE_10_X runtime to allow inline code in CloudFormation, per
aws-cloudformation/cloudformation-coverage-roadmap#80.

close #4653, close #4642
@nija-at nija-at self-assigned this Nov 18, 2019
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 18, 2019
@mergify
Copy link
Contributor

mergify bot commented Nov 18, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist
:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@nija-at nija-at added the pr/do-not-merge This PR should not be merged at this time. label Nov 18, 2019
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@nija-at nija-at merged commit 7a3a3b1 into master Nov 18, 2019
@nija-at nija-at deleted the nija-at/node10 branch November 18, 2019 16:37
@nija-at nija-at removed the pr/do-not-merge This PR should not be merged at this time. label Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
3 participants