-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade all uses of node8.10 lambda runtime to node10.x #5075
Conversation
Update NODE_10_X runtime to allow inline code in CloudFormation, per aws-cloudformation/cloudformation-coverage-roadmap#80. close #4653, close #4642
Thanks so much for taking the time to contribute to the AWS CDK ❤️ We will shortly assign someone to review this pull request and help get it
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Upgrade all internal uses of Node8.10 lambda runtime to Node10.X.
This includes all exported constructs that contain a lambda function within them.
Update NODE_10_X runtime to allow inline code in CloudFormation, per
aws-cloudformation/cloudformation-coverage-roadmap#80.
Shout out to @nmussy who got this most of the way (#4655)
close #4653, close #4642
Additional Testing
DropSpamReceiptRule
,AwsApi RuleTarget
,LogRetention
,GlobalTableCoordinator
DropSpamReceiptRule
uses inline code with Node10. Successfully deployed to a stack and the function execution verified.NotificationsResourceHandler
construct, which is not using the default Lambda module, also works when updated to Node10.x.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license