Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ecs-patterns): create dlq when queue is not provided for QueueProcessingService #6356

Merged
merged 12 commits into from Feb 20, 2020
Merged

feat(ecs-patterns): create dlq when queue is not provided for QueueProcessingService #6356

merged 12 commits into from Feb 20, 2020

Conversation

SeekerWing
Copy link
Contributor

@SeekerWing SeekerWing commented Feb 19, 2020 •
edited by piradeepk

When a queue is not provided as input, create a queue as well as it's corresponding deadletterqueue(dlq), and define the redrive policy for when messages are sent to the dlq.

Not considered a breaking change as RedrivePolicy and MessageRetentionPeriod can be added with no interruption.

Fixes #6352

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 80c49a5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: b24ace7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: fd91ae0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

piradeepk
piradeepk previously requested changes Feb 19, 2020
View reviewed changes
Copy link
Contributor

@piradeepk piradeepk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SeekerWing this is awesome! Thanks for taking the time to add this for users! I had a couple minor comments, let me know if you'd like to discuss them further

packages/@aws-cdk/aws-ecs-patterns/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-ecs-patterns/lib/base/queue-processing-service-base.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-ecs-patterns/lib/base/queue-processing-service-base.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-ecs-patterns/lib/base/queue-processing-service-base.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-ecs-patterns/lib/base/queue-processing-service-base.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-ecs-patterns/lib/base/queue-processing-service-base.ts Outdated Show resolved Hide resolved
@mergify mergify bot dismissed piradeepk’s stale review February 19, 2020 18:44

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 6f2560b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 0f33f7c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@piradeepk piradeepk changed the title feat(aws-ecs-patterns): setup associated DLQ when Queue created by CDK for QueueProcessingFargateService feat(ecs-patterns): create associated DLQ when Queue is not provided for QueueProcessingService Feb 19, 2020
@piradeepk piradeepk changed the title feat(ecs-patterns): create associated DLQ when Queue is not provided for QueueProcessingService feat(ecs-patterns): create associated DLQ when queue is not provided for QueueProcessingService Feb 19, 2020
@piradeepk piradeepk changed the title feat(ecs-patterns): create associated DLQ when queue is not provided for QueueProcessingService feat(ecs-patterns): create dlq when queue is not provided for QueueProcessingService Feb 19, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: ffb7e2e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: a466e66
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: c39716a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@piradeepk piradeepk added @aws-cdk/aws-ecs Related to Amazon Elastic Container @aws-cdk/aws-ecs-patterns Related to ecs-patterns library labels Feb 20, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: a45cd7f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 3bddd35
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

piradeepk
piradeepk previously requested changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@piradeepk piradeepk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Can you also add tests for when the maxReceiveCount and the retentionPeriod are overridden?

@mergify mergify bot dismissed piradeepk’s stale review February 20, 2020 17:16

Pull request has been modified.

piradeepk
piradeepk approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@piradeepk piradeepk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it! @SeekerWing, thanks for taking the time to add this feature!

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 4c18e46
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: faedf6b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Feb 20, 2020

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot merged commit e307d7f into aws:master Feb 20, 2020
@SeekerWing SeekerWing deleted the ecs_dlq branch February 23, 2020 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piradeepk piradeepk piradeepk approved these changes

Assignees

@piradeepk piradeepk

Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container @aws-cdk/aws-ecs-patterns Related to ecs-patterns library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

setup DLQ for auto generated Queue in @aws-cdk_aws-ecs-patterns QueueProcessingFargateService
4 participants
@SeekerWing @aws-cdk-automation @piradeepk @SoManyHs