Potential logical ID conflict between top-level resource

[eladb]

If two top-level resources (resources defined directly under a stack) have logical IDs that only differ by non alpha-numeric characters, they will get the same logical ID and will conflict.

Sadly, we can't fix this bug without a breaking change in 1.x, so we should consider fixing this in v2.0.

Reproduction Steps

const stack = new Stack();
const r1 = new Resource(stack, 'a-b');
const r2 = new Resource(stack, 'ab');

In this case, both r1 and r2 will get the logical ID ab because we filter non-alphanumeric characters from the logical ID for top-level resources.

Other

The code is here:

aws-cdk/packages/@aws-cdk/core/lib/private/uniqueid.ts

Line 49 in 031932d

return removeNonAlphanumeric(components[0]);

---

This is 🐛 Bug Report

[eladb]

We will not be able to make any changes to how logical IDs are rendered. We will have to leave with this forever and ever... Sorry.