Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ApplicationLoadBalancedEc2Service does not create domain since 1.31.0 #7148

Closed
konstantinj opened this issue Apr 2, 2020 · 5 comments
Closed
Assignees
Labels
@aws-cdk/aws-ecs-patterns Related to ecs-patterns library @aws-cdk/aws-route53 Related to Amazon Route 53 bug This issue is a bug. needs-reproduction This issue needs reproduction. p0

Comments

@konstantinj
Copy link

I've tested 3 of our applications and with none of it I'm getting a AWS::Route53::RecordSet in my cloudformation template when using the ApplicationLoadBalancedEc2Service in version 1.31.0. After rolling back all packages and the cdk cli to 1.30.0 I'm getting the AWS::Route53::RecordSet again.

Reproduction Steps

        const service = new ApplicationLoadBalancedEc2Service(this, 'Service', {
            publicLoadBalancer: false,
            memoryReservationMiB: 1024,
            domainZone: hostedZone,
            domainName: 'test.de',
            protocol: ApplicationProtocol.HTTPS,
            cluster: cluster,
            desiredCount: 1,
            healthCheckGracePeriod: Duration.seconds(120),
            maxHealthyPercent: 100,
            minHealthyPercent: 0,
            taskImageOptions: {
                image: ContainerImage.fromAsset('app/'),
                containerPort: 80,
            }
        })

Environment

  • CLI Version : 1.31.0
  • Framework Version: 1.31.0
  • OS : OSX
  • Language : Typescript

This is 🐛 Bug Report

@konstantinj konstantinj added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Apr 2, 2020
@SomayaB SomayaB added the @aws-cdk/aws-ecs-patterns Related to ecs-patterns library label Apr 3, 2020
@SoManyHs SoManyHs added @aws-cdk/aws-route53 Related to Amazon Route 53 needs-reproduction This issue needs reproduction. p1 and removed needs-triage This issue or PR still needs to be triaged. labels Apr 6, 2020
@SoManyHs
Copy link
Contributor

SoManyHs commented Apr 6, 2020

Related: #6992

@SoManyHs
Copy link
Contributor

SoManyHs commented Apr 6, 2020

Related: #6987

@SoManyHs
Copy link
Contributor

SoManyHs commented Apr 6, 2020

Related: #6702

@MrArnoldPalmer MrArnoldPalmer added p0 and removed p1 labels Apr 6, 2020
@hencrice
Copy link
Contributor

hencrice commented Apr 6, 2020

We've reverted the breaking change in #6987. Pending release

@MrArnoldPalmer
Copy link
Contributor

The revert is in v1.32.0. Let us know if you're still having problems. We are discussing future steps with regards to the creation of these records in this issue here if you have any input.
#7206

reopen if you still have issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ecs-patterns Related to ecs-patterns library @aws-cdk/aws-route53 Related to Amazon Route 53 bug This issue is a bug. needs-reproduction This issue needs reproduction. p0
Projects
None yet
Development

No branches or pull requests

6 participants