Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workshop (Python) should advise about RetentionPolicy #7403

Closed
telenieko opened this issue Apr 17, 2020 · 1 comment
Closed

Workshop (Python) should advise about RetentionPolicy #7403

telenieko opened this issue Apr 17, 2020 · 1 comment
Assignees
Labels
documentation This is a problem with documentation. feature-request A feature should be added or improved. language/python Related to Python bindings needs-triage This issue or PR still needs to be triaged.

Comments

@telenieko
Copy link

Hi,

I just got bit by #3476, it is stated that this is intentional and documented but...

Given it's a workshop, one would expect that the last step would destroy all created resources, which does not happen and there's no warning about it.

The Workshop should either:

  • In the Congrats page, when telling you to cdk destroy advise that the DynamoDB table will not be deleted (extra points for a link to the RetentionPolicy docs)
  • When creating the table, set removalPolicy: RemovalPolicy.DESTROY and explain it

Option two would be preferable as it explains something quite useful.


This is a 📕 documentation issue

@telenieko telenieko added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Apr 17, 2020
@SomayaB SomayaB added the language/python Related to Python bindings label Apr 20, 2020
@SomayaB SomayaB assigned NGL321 and SomayaB and unassigned SomayaB Apr 20, 2020
@SomayaB SomayaB added the documentation This is a problem with documentation. label Apr 20, 2020
@SomayaB
Copy link
Contributor

SomayaB commented Apr 20, 2020

Hi @telenieko, thanks for submitting this issue. I think it is a fair ask. I've created a new issue for it in the Workshop repo here and will be closing this one.

@SomayaB SomayaB closed this as completed Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This is a problem with documentation. feature-request A feature should be added or improved. language/python Related to Python bindings needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Development

No branches or pull requests

3 participants