fix(toolkit): CLI tool fails on CloudFormation Throttling #8711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CDK (particularly, `cdk deploy`) might crash after getting throttled by CloudFormation, after the default configured 6 retries has been reached. This changes the retry configuration of the CloudFormation client (and only that one) to allow up to 10 retries with a backoff base of 1 second. This makes the maximum back-off about 17 minutes, which I hope would be plenty enough even for the 1 TPM calls. This should allow heavily parallel deployments on the same account and region to avoid getting killed by a throttle; but will reduce the responsiveness of the progress UI. Additionaly, configured a custom logger for the SDK, which would log the SDK calls to the console when running in debug mode, allowing the users to gain visibility on more information for troubleshooting purposes. Fixes #5637
RomainMuller
force-pushed
the
rmuller/retry-cloudformation-calls
branch
from
daca70d
to
c94d386
Compare
RomainMuller
added
pr-linter/exempt-readme
rix0rrr
approved these changes
Jun 24, 2020
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CDK (particularly,
cdk deploy) might crash after getting throttledby CloudFormation, after the default configured 6 retries has been
reached.
This changes the retry configuration of the CloudFormation client (and
only that one) to allow up to 10 retries with a backoff base of 1
second. This makes the maximum back-off about 17 minutes, which I hope
would be plenty enough even for the 1 TPM calls. This should allow
heavily parallel deployments on the same account and region to avoid
getting killed by a throttle; but will reduce the responsiveness of the
progress UI.
Additionaly, configured a custom logger for the SDK, which would log the
SDK calls and other information
Fixes #5637
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license