Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apigateway): Lambda integration for imported functions #8870

Merged

Conversation

iliapolo
Copy link
Contributor

@iliapolo iliapolo commented Jul 2, 2020

Use instanceof to identify real functions vs imported ones and appropriately use whats needed to extract the function name.

Fixes #8869


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@iliapolo iliapolo requested a review from nija-at July 2, 2020 16:00
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 2, 2020
@nija-at nija-at added the pr/do-not-merge This PR should not be merged at this time. label Jul 2, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 691e1e3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@iliapolo
Copy link
Contributor Author

iliapolo commented Jul 2, 2020

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Jul 2, 2020

Command refresh: success

@iliapolo iliapolo removed the pr/do-not-merge This PR should not be merged at this time. label Jul 2, 2020
@iliapolo
Copy link
Contributor Author

iliapolo commented Jul 2, 2020

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Jul 2, 2020

Command refresh: success

@mergify
Copy link
Contributor

mergify bot commented Jul 2, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 8420f96 into master Jul 2, 2020
@mergify mergify bot deleted the epolon/fix-lambda-apigw-integration-imported-function branch July 2, 2020 16:30
iliapolo added a commit that referenced this pull request Jul 2, 2020
Use `instanceof` to identify real functions vs imported ones and appropriately use whats needed to extract the function name.

Fixes #8869

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[aws-apigateway] Lambda integration broken for imported functions
3 participants