fix(cli): cli integ tests do not have a unique stack prefix #9165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stack prefixes only included the codebuild project _name_ and not the build id. There was also some legacy support in which the test prefix was `cdk-toolkit-canary` or `cdk-toolkit-integration` and it seems like these prefixes are no longer required. This resulted in canaries failing when two instances executed concurrently: the "cleanup" code of one canary deleted stacks in-flight for the other canary. We now simply use a timestamp to generate a unique prefix for each test run in order to isolate these stacks.
iliapolo
approved these changes
Jul 20, 2020
njlynch
reviewed
Jul 20, 2020
No, this is where the app takes in the environment variable. But you know what? Let me change this so that it will fail if the environment variable is not defined, so we can avoid future mistakes. |
|
@njlynch fixed |
njlynch
approved these changes
Jul 20, 2020
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Chriscbr
pushed a commit
to Chriscbr/aws-cdk
that referenced
this pull request
Jul 23, 2020
Stack prefixes only included the codebuild project _name_ and not the build id. There was also some legacy support in which the test prefix was `cdk-toolkit-canary` or `cdk-toolkit-integration` and it seems like these prefixes are no longer required. This resulted in canaries failing when two instances executed concurrently: the "cleanup" code of one canary deleted stacks in-flight for the other canary. We now simply use a timestamp to generate a unique prefix for each test run in order to isolate these stacks.
curtiseppel
pushed a commit
to curtiseppel/aws-cdk
that referenced
this pull request
Aug 11, 2020
Stack prefixes only included the codebuild project _name_ and not the build id. There was also some legacy support in which the test prefix was `cdk-toolkit-canary` or `cdk-toolkit-integration` and it seems like these prefixes are no longer required. This resulted in canaries failing when two instances executed concurrently: the "cleanup" code of one canary deleted stacks in-flight for the other canary. We now simply use a timestamp to generate a unique prefix for each test run in order to isolate these stacks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack prefixes only included the codebuild project name and not the build id. There was also some legacy support in which the test prefix was
cdk-toolkit-canaryorcdk-toolkit-integrationand it seems like these prefixes are no longer required.This resulted in canaries failing when two instances executed concurrently: the "cleanup" code of one canary deleted stacks in-flight for the other canary.
We now simply use a timestamp to generate a unique prefix for each test run in order to isolate these stacks.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license