chore(cloudfront): small refactoring of the Origin API #9281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njlynch
reviewed
Jul 28, 2020
packages/@aws-cdk/aws-cloudfront/test/private/cache-behavior.test.ts
Outdated
Show resolved
Hide resolved
skinny85
force-pushed
the
feat/cloudfront-origin-groups-refactor
branch
from
d4901c5
to
934a50c
Compare
|
@njlynch this is ready for another round of reviews. I've incorporated all of your comments, and I've also reverted the renaming of |
njlynch
approved these changes
Jul 29, 2020
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
curtiseppel
pushed a commit
to curtiseppel/aws-cdk
that referenced
this pull request
Aug 11, 2020
Change the Origin to an interface, from an abstract class, and change its `bind` protocol to return an `OriginBindConfig` interface. This is in preparation for handling Origin Groups in aws#9109 - when time comes to handle Origin Groups, we will add a new (optional) property to `OriginBindConfig`, of type `CfnDistribution.OriginGroupProperty`, and handle it in `Distribution`. BREAKING CHANGE: the property Origin.domainName has been removed ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the Origin to an interface, from an abstract class, and change its
bindprotocol to return anOriginBindConfiginterface.This is in preparation for handling Origin Groups in #9109 - when time comes to handle Origin Groups, we will add a new (optional) property to
OriginBindConfig, of typeCfnDistribution.OriginGroupProperty, and handle it inDistribution.BREAKING CHANGE: the property Origin.domainName has been removed
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license