Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cfn-include): add support for retrieving Rule objects from the template #9783

Merged
merged 1 commit into from Aug 19, 2020

Conversation

skinny85
Copy link
Contributor

Fixes #9712


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 18, 2020
@skinny85
Copy link
Contributor Author

Missing ReadMe changes - will add.

packages/@aws-cdk/core/lib/cfn-parse.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/core/lib/cfn-parse.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/core/lib/cfn-parse.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/core/lib/cfn-parse.ts Show resolved Hide resolved
@skinny85 skinny85 force-pushed the feat/cfn-include-get-rule branch 2 times, most recently from 4f66e5f to 5a63a7b Compare August 19, 2020 00:26
@skinny85 skinny85 requested a review from njlynch August 19, 2020 00:36
@mergify
Copy link
Contributor

mergify bot commented Aug 19, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: d82686d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Aug 19, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit e4720bf into aws:master Aug 19, 2020
@skinny85 skinny85 deleted the feat/cfn-include-get-rule branch August 19, 2020 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cfn-include] Add support for retrieving Rule objects from the template
3 participants