Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Importing ABC directly from collections module will be ImportError in Python 3.9 #4853

Closed
tirkarthi opened this issue Jan 19, 2020 · 1 comment · Fixed by #4860
Closed

Importing ABC directly from collections module will be ImportError in Python 3.9 #4853

tirkarthi opened this issue Jan 19, 2020 · 1 comment · Fixed by #4860

Comments

@tirkarthi
Copy link

This was emitting deprecation warning from Python 3.4 and it will stop working in Python 3.9 . Reference : python/cpython#10596 . There is already awscli/compat.py so it would be good to import ABC from collections_abc that has Python 2 and 3 compatibility.

Thanks for the library!

awscli/customizations/history/db.py
19:from collections import MutableMapping
tests/__init__.py
1:from collections import MutableMapping
2:from collections import Mapping
@hugovk hugovk mentioned this issue Jan 21, 2020
Merged
@hugovk
Copy link
Contributor

hugovk commented Jan 21, 2020

Please see PR #4860.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix collections.abc imports for Python 3.9 hugovk/aws-cli
2 participants
@hugovk @tirkarthi