Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update colorama version for compatibility with pylint #7086

Closed
sbrunner opened this issue Jul 4, 2022 · 16 comments · Fixed by #8122
Closed

Update colorama version for compatibility with pylint #7086

sbrunner opened this issue Jul 4, 2022 · 16 comments · Fixed by #8122
Labels
dependencies This issue is a problem in a dependency. feature-request A feature should be added or improved. p2 This is a standard priority issue third-party This issue is related to third-party libraries or applications.

Comments

@sbrunner
Copy link

sbrunner commented Jul 4, 2022

Describe the bug

Install awscli with pylint at latest version (2.14.4) with e.g. poetry

Expected Behavior

Working

Current Behavior

I get the error:

  Because awscli (1.25.22) depends on colorama (>=0.2.5,<0.4.5)
   and pylint (2.14.4) depends on colorama (>=0.4.5), awscli (1.25.22) is incompatible with pylint (2.14.4).

Reproduction Steps

Install awscli with pylint at latest version (2.14.4) with e.g. poetry

Possible Solution

Update the colorama>=0.2.5,<0.4.5' dependency
https://github.com/aws/aws-cli/blob/develop/setup.py

It looks like that just for security against new release.

Additional Information/Context

No response

CLI version used

1.25.22

Environment details (OS name and version, etc.)

Ubuntu 20.04

@sbrunner sbrunner added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jul 4, 2022
@tim-finnigan tim-finnigan changed the title (short issue description) Update colorama version for compatibility with pylint Jul 5, 2022
@tim-finnigan tim-finnigan self-assigned this Jul 5, 2022
@tim-finnigan tim-finnigan added investigating This issue is being investigated and/or work is in progress to resolve the issue. feature-request A feature should be added or improved. and removed bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jul 5, 2022
@tim-finnigan
Copy link
Contributor

Hi @sbrunner thanks for reaching out. It looks like colorama v0.4.5 was just released on June 16, 2022: https://pypi.org/project/colorama/#history. We also had a recent PR to allow colorama upgrades up to v0.4.4. We’ll need to look through the changelog but this is something we should be able to update.

@tim-finnigan tim-finnigan added third-party This issue is related to third-party libraries or applications. and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Jul 6, 2022
@naslundx
Copy link

Any updates on this? Also facing the same problem - it's not possible to use awscli and pylint in the same project.

@tim-finnigan
Copy link
Contributor

Hi @naslundx thanks for checking in. The team is currently working on improving dependency management as it relates to the AWS CLI. There's another issue tracking that here: #5943. I can't give a definite timeline but expect that in the near future colorama will be updated as part of this broader work.

@naslundx
Copy link

@tim-finnigan Thanks for the quick response!

@tim-finnigan
Copy link
Contributor

Sure! I think this issue can now be closed as #7380 (review) was just merged.

@tim-finnigan tim-finnigan added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Nov 1, 2022
@glaubitz
Copy link

glaubitz commented Nov 2, 2022

This should be bumped to at least colorama <= 0.4.6 as 0.4.6 is now the current version of the colorama package.

@github-actions github-actions bot removed the closing-soon This issue will automatically close in 4 days unless further comments are made. label Nov 2, 2022
@tim-finnigan
Copy link
Contributor

@glaubitz In that pr I referenced above the ceiling for colorama was set to <0.4.7 so 0.4.6 should be included.

@tim-finnigan tim-finnigan added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Nov 2, 2022
@glaubitz
Copy link

glaubitz commented Nov 2, 2022

Ah, I missed that reference. 0.4.7 sounds good. Thanks!

@github-actions
Copy link

github-actions bot commented Nov 2, 2022

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.

@tim-finnigan tim-finnigan reopened this Nov 2, 2022
@tim-finnigan
Copy link
Contributor

Reopening due to #7395.

@github-actions github-actions bot removed the closing-soon This issue will automatically close in 4 days unless further comments are made. label Nov 2, 2022
@bmw
Copy link

bmw commented Nov 7, 2022

Will this change also be made for awscli v1?

@tim-finnigan
Copy link
Contributor

@bmw dependabot was just recently added for v2 to increase version ranges like this one but it is not currently prioritized for v1.

@bmw
Copy link

bmw commented Nov 10, 2022

Thanks for the info.

Since it seems v2 is usually installed in a separate environment with a bundled copy of Python, I suspect most people tracking this issue are interested in seeing it fixed for v1.

@tim-finnigan tim-finnigan added p2 This is a standard priority issue dependencies This issue is a problem in a dependency. labels Nov 11, 2022
@tim-finnigan tim-finnigan removed their assignment Nov 11, 2022
@gradientsky
Copy link

Conflict with tox:

$ pipdeptree -r -p colorama
Warning!!! Possibly conflicting dependencies found:
* tox==4.2.8
 - colorama [required: >=0.4.6, installed: 0.4.4]
------------------------------------------------------------------------
colorama==0.4.4
  - awscli==1.27.59 [requires: colorama>=0.2.5,<0.4.5]
  - tox==4.2.8 [requires: colorama>=0.4.6]

@aguckenber-chwy
Copy link

Still waiting on this fix.

@kdaily kdaily linked a pull request Apr 25, 2024 that will close this issue
Copy link

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies This issue is a problem in a dependency. feature-request A feature should be added or improved. p2 This is a standard priority issue third-party This issue is related to third-party libraries or applications.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants