-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting :max-revisions to 0 prevents new deployments #57
Comments
An excerpt from the log with debug level enabled (for some reason every line in my log is doubled, but I removed the duplicates here):
|
You are correct. We have created task to fix this issue and roll out updated version soon. Thanks for letting us know! |
This fix is written up and will be released in next release of host agent. |
So, has this been released yet? Btw, if changing this value to |
was this released? |
any updates ? |
Hi, We are currently working on the fix. The deployments will fail because the agent will not start with the max_revisions set to 0. Right now only integers 1 or greater work. Thank you |
@mxro Superfluous copies will not be automatically deleted immediately. They will be deleted at the beginning of the next deployment. |
Hi, Through many talks with managers, we have concluded we do not plan on supporting setting max_revision to 0 because of rollbacks and other functionality that relies on this. There are ways to work around this if you'd like. you can turn on the setting to ignore ApplicationStop failures and use a script to remove all old deployments. Thank you |
Please refer to this post for the issue description: https://forums.aws.amazon.com/thread.jspa?messageID=711273
Based on my reading of the code, this is what happens:
command_executor#execute_command
is called with command =DownloadBundle
.download_bundle
which performs a cleanup: https://github.com/aws/aws-codedeploy-agent/blob/master/lib/instance_agent/plugins/codedeploy/command_executor.rb#L71.:max-revisions = 0
,cleanup_old_archives
removes all the deployment directories except for the last successful one, including the newly-created one.download_from_s3
: https://github.com/aws/aws-codedeploy-agent/blob/master/lib/instance_agent/plugins/codedeploy/command_executor.rb#L207.You either need to keep track of and exclude the newly-created directory from the cleanup, or perform the cleanup before creating new directories.
After I set
:max-revisions
to 2, the deployments were able to proceed.The text was updated successfully, but these errors were encountered: