Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested event structure definitions cause downstream code generation problems #276

Closed
ewbankkit opened this issue Mar 31, 2020 · 1 comment · Fixed by #278
Closed

Nested event structure definitions cause downstream code generation problems #276

ewbankkit opened this issue Mar 31, 2020 · 1 comment · Fixed by #278

Comments

@ewbankkit
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Rust event types for AWS Lambda are generated from this project's event definitions and the recent introduction of nested Go structure definitions in APIGatewayV2HTTPRequestContext via #274 has caused Rust code generation to fail (Rust has no nested structure definitions).

Describe the solution you'd like
Would it be possible to declare all event types as top-level structures?

Describe alternatives you've considered
In the short term a blacklist for structures that can't be handled could be introduced but the long term alternative would be significant work to rejig the Rust code generator.

@bmoffatt
Copy link
Collaborator

bmoffatt commented Apr 1, 2020

Would it be possible to declare all event types as top-level structures?

Seems fine to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants