Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Automatic-Module-Name' property to aws-lambda-java-core MANIFEST.MF #142

Open
jhg023 opened this issue Jun 6, 2020 · 3 comments
Open

Comments

@jhg023
Copy link

jhg023 commented Jun 6, 2020

aws-lambda-java-core's lack of an Automatic-Module-Name property in its META-INF/MANIFEST.MF is preventing me from modularizing my Java project.

Attempting to require the automatic module in my module-info.java with
requires aws.lambda.java.core; results in the following Gradle error:

> Task :*******:compileJava FAILED
C:\Users\Jacob\IdeaProjects\***-******-*********\*******\src\main\java\module-info.java:4: error: module not found: aws.lambda.java.core
    requires aws.lambda.java.core;

Environment:

C:\Users\Jacob\IdeaProjects\***-******-*********>gradlew -v

------------------------------------------------------------
Gradle 6.5
------------------------------------------------------------

Build time:   2020-06-02 20:46:21 UTC
Revision:     a27f41e4ae5e8a41ab9b19f8dd6d86d7b384dad4

Kotlin:       1.3.72
Groovy:       2.5.11
Ant:          Apache Ant(TM) version 1.10.7 compiled on September 1 2019
JVM:          14.0.1 (Oracle Corporation 14.0.1+7)
OS:           Windows 10 10.0 amd64
@msailes
Copy link
Collaborator

msailes commented Jun 8, 2020

Hi Jacob,

Thanks for raising this issue.

I think named will be important here, I'll throw out these ideas. A combination of the groupId and the key parts of the artifactId.

com.amazonaws.lambda.core
com.amazonaws.lambda.events
com.amazonaws.lambda.eventstransformer
com.amazonaws.lambda.log4j
com.amazonaws.lambda.log4j2

Thoughts?

@jhg023
Copy link
Author

jhg023 commented Jun 8, 2020

Mark,

Thanks for the quick response.

I agree with the names you've suggested. However, I'm not sure if it's recommended to suffix a module name with a digit (com.amazonaws.lambda.log4j2), but I'm not able to suggest anything better.

@SingingBush
Copy link

I've done as PR using the following naming convention for module names:

aws.lambda.core
aws.lambda.events
aws.lambda.events.sdk.transformer
aws.lambda.log4j2
aws.lambda.runtime.interface.client
aws.lambda.serialization

I'm happy to rename them to com.amazonaws.lambda.* instead of aws.lambda.* if required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants