Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing apache configs is too strict #73

Open
leonblueconic opened this issue Mar 24, 2023 · 3 comments
Open

Parsing apache configs is too strict #73

leonblueconic opened this issue Mar 24, 2023 · 3 comments
Labels
good first issue Good for newcomers

Comments

@leonblueconic
Copy link

When trying to setup nitro-enclaves-acm in conjunction with Apache httpd it took me a large part of the day to find out the replacements for SSLCertificateKeyFile & SSLCertificateFile will not be done when both entries are not at the start of a line. As normally http config files are indented to make them more readable I suspect a lot of people will run into this when migrating existing httpd configs for use with nitro enclaves. Please modify the code that it will allow for whitespace at the start of the line.

@alcioa alcioa added the good first issue Good for newcomers label Mar 27, 2023
@alcioa
Copy link
Contributor

alcioa commented Mar 27, 2023

Mentioned here - https://github.com/aws/aws-nitro-enclaves-acm/blob/main/docs/httpd.md as it takes mod_ssl ssl.conf as default.

@leonblueconic
Copy link
Author

In that case it might make sense to also add the note to: https://docs.aws.amazon.com/enclaves/latest/user/nitro-enclave-refapp.html. Or just fix the code and trim whitespace from the lines before matching up the lines.

@ggrandes
Copy link

@leonblueconic : Maybe you want make a "dummy-acm.conf" file with SSLCertificateKeyFile & SSLCertificateFile and use "Include" in your well-indented source pointing to that dummy-acm.conf?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants