Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use with managed node groups #186

Closed
kostas-rs opened this issue Jun 30, 2020 · 4 comments
Closed

Use with managed node groups #186

kostas-rs opened this issue Jun 30, 2020 · 4 comments
Labels
Type: Question All types of questions to/from customers

Comments

@kostas-rs
Copy link

Hi,

Since managed node groups were introduced, according to AWS:

Amazon EKS automatically drains nodes using the Kubernetes API during terminations or updates. Updates respect the pod disruption budgets that you set for your pods.

Does this mean aws-node-termination-handler is not required when used in conjunction with managed node groups during maintenance events? Does anyone have some experience around that?

Also with managed node groups backed by spot instances in the horizon it would be good to get some clarity in case there is overlapping functionality.

Thank you

@jaypipes jaypipes added the Type: Question All types of questions to/from customers label Jul 6, 2020
@bwagner5
Copy link
Contributor

bwagner5 commented Jul 6, 2020

@kostas-rs EKS managed node groups use ASG lifecycle hooks to drain nodes based on ASG termination events. The health checks that ASG performs take into account EC2 status checks which include EC2 scheduled maintenance events (https://docs.aws.amazon.com/autoscaling/ec2/userguide/healthcheck.html). If you're using EKS managed node groups, you should not need the aws-node-termination-handler for the managed nodes.

@kostas-rs
Copy link
Author

Thank you @bwagner5.

@mtparet
Copy link

mtparet commented Aug 31, 2022

The health checks that ASG performs take into account EC2 status checks which include EC2 scheduled maintenance events

But what about spot instances ? Does it drain also ec2 instances automatically ?

@snay2
Copy link
Contributor

snay2 commented Aug 31, 2022

Yes, EKS managed node groups will drain EC2 Spot instances when appropriate. Per the documentation:

When a replacement Spot node is bootstrapped and in the Ready state on Kubernetes, Amazon EKS cordons and drains the Spot node that received the rebalance recommendation.

and

If a Spot two-minute interruption notice arrives before the replacement Spot node is in a Ready state, Amazon EKS starts draining the Spot node that received the rebalance recommendation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Question All types of questions to/from customers
Projects
None yet
Development

No branches or pull requests

5 participants