Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wizard allows mandatory fields to be skipped #991

Closed
adriantadros opened this issue Oct 26, 2023 · 2 comments
Closed

Wizard allows mandatory fields to be skipped #991

adriantadros opened this issue Oct 26, 2023 · 2 comments
Labels
bug Something isn't working released

Comments

@adriantadros
Copy link

Describe the bug
In the Wizard form renderer component, it is possible for the user to skip mandatory fields in a step. The user is able to submit the form with invalid data (i.e. valid form submission but missing mandatory fields).

Versions
Latest

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://aws.github.io/aws-northstar/?path=/story/components-formrenderer-wizard--default
  2. Enter a value for "Config 1"
  3. Click Next to go to Step 2
  4. Enter a value for "Config 2"
  5. Click Next to go to Step 3
  6. Click Next to go to Step 4
  7. Click on Step 2 in the wizard navigation menu to go back to Step 2
  8. Remove text in the "Config 2" textbox
  9. Click on Step 1 in the wizard navigation menu
  10. Click on Step 4
  11. Click submit
  12. The form submits successfully - { "config1": "some value" }

Expected behavior
All fields should be validated before submission.

i.e. The form should not allow the user to submit it unless there is a config2 value, i.e. { "config1": "some value", "config2": "some value" }

Additional context
This is a bit of an edge case, but technically this bug makes it possible for a user to submit an invalid form.

@adriantadros adriantadros added the bug Something isn't working label Oct 26, 2023
@jessieweiyi
Copy link
Contributor

Thanks for reporting the bug and the detailed steps to reproduce. Please be confirmed that we can reproduce in our environment. We will look into fixing the bug in next few days.

@aws-prototyping-bot
Copy link
Collaborator

🎉 This issue has been resolved in version @aws-northstar/ui-v1.1.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

No branches or pull requests

3 participants