Add price-capacity-optimized AllocationStrategy #6192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can a team member please review this. |
|
Thank you for the contribution! Would it be possible for you to add an integration test or add this feature to an existing integration test and verify it's functionality as part of this PR? That would help expedite inclusion in a future release. Thanks! |
|
@dreambeyondorange I have added an integration test |
LGTM! Can you just add an update to the Changelog to include the new feature? Looks like there are a couple linter errors as well. Once you add these I should be able to approve and merge! |
|
Updated! |
dreambeyondorange
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6058