Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure python poetry envs are created when installing #720

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

agdimech
Copy link
Contributor

@agdimech agdimech commented Mar 13, 2024

  • use pnpm instead of yarn for non-node projects.
  • force usage of pyenv as a global dependency as this leads to more predicatable installs/builds and less errors to do with python aliases, etc
  • Ensure all non-node projects have their install:ci target called as part of the root install:ci script
  • Ensure all python projects call poetry env use pythonXXX before installing to ensure the venv is setup correctly.
    • The logic here is to parse the pyproject.toml and fetch the listed python version. If it starts with a '^', we fetch the latest installed python version from the user's machine matching the major version. If the version is pinned, then we use that version.
  • Update docs to mention pyenv should be used.
  • Replace yarn with pnpm in getting started.

@agdimech agdimech marked this pull request as draft March 13, 2024 11:22
Copy link
Member

@cogwirrel cogwirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this is going to make python a lot more robust :)

@agdimech agdimech marked this pull request as ready for review March 14, 2024 00:42
@agdimech agdimech merged commit 984d71e into mainline Mar 14, 2024
5 checks passed
@agdimech agdimech deleted the fix/poetry_env branch March 14, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants