Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(open-api-gateway): typescript handler input as single object with typed event/context #151

Merged
merged 2 commits into from
Sep 7, 2022

Conversation

cogwirrel
Copy link
Member

For better consistency with the python and java interceptors and for easier extensibility in the
future, accept a single object as the request for typescript interceptors. Use @types/aws-lambda to
provide types for event/context instead of any. As with java and python, include an
interceptorContext object dedicated for use by interceptors to pass state to other
interceptors/handlers.

BREAKING CHANGE: Typescript handler methods now accept a single object with input, event, context
rather than as separate arguments.

…h typed event/context

For better consistency with the python and java interceptors and for easier extensibility in the
future, accept a single object as the request for typescript interceptors. Use @types/aws-lambda to
provide types for event/context instead of any. As with java and python, include an
"interceptorContext" object dedicated for use by interceptors to pass state to other
interceptors/handlers.

BREAKING CHANGE: Typescript handler methods now accept a single object with input, event, context
rather than as separate arguments.
@nx-cloud
Copy link

nx-cloud bot commented Sep 5, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 658231c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@cogwirrel cogwirrel merged commit 431dbec into mainline Sep 7, 2022
@cogwirrel cogwirrel deleted the feat/typescript-handler-improvements branch September 7, 2022 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants