fix(nx-monorepo): resolve dependencies in node subprojects #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportAttention: This version of the Nx Cloud GitHub bot will cease to function on July 1st, 2023. An organization admin can update your integration here. CI is running/has finished running commands for commit bb41150. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
BradenM
changed the title
Signed-off-by: Braden Mars <bradenmars@bradenmars.me>
…ution Signed-off-by: Braden Mars <bradenmars@bradenmars.me>
Signed-off-by: Braden Mars <bradenmars@bradenmars.me>
BradenM
force-pushed
the
fix/nx-mono-subprojects-deps
branch
from
2c11d23
to
9c1e651
Compare
…ust assert non wildcard Signed-off-by: Braden Mars <bradenmars@bradenmars.me>
BradenM
force-pushed
the
fix/nx-mono-subprojects-deps
branch
from
9c1e651
to
7c3b50c
Compare
|
Good catch! Awesome PR :) |
cogwirrel
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #379 and projen/projen#2641
The current logic in-place essentially skips resolution of sub-project dependencies entirely (as described by @mrgrain in projen/projen#2641 (comment)).
As a result of this, dependencies added to child projects will always be '*' unless manually pinned or edited with a scope.
Neither
projen upgradenorprojen upgrade-depswill update this for you as of now either (at least from '*' that is), so it requires manual intervention.In the aim of resolving this problem, this PR modifies the synth process to ensure subprojects will be resolved only after the workspace root has had a chance to install any changes.
This is based on @mrgrain 's mockup seen here: #379 (comment)